Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: try to make sleeping portable by avoiding select #5035

Closed
wants to merge 1 commit into from

Conversation

mback2k
Copy link
Member

@mback2k mback2k commented Mar 4, 2020

select does not support just waiting on Windows:
https://perldoc.perl.org/perlport.html#select

Another attempt to work on #5022 and #5034.

@mback2k mback2k force-pushed the fix-sleeping-in-testsuite branch 2 times, most recently from 1c9a3a1 to 10cb3dc Compare March 4, 2020 09:25
@mback2k
Copy link
Member Author

mback2k commented Mar 4, 2020

Cool side effect, this is speeding up even the Linux and MacOS CI builds by roughly 5 minutes. :-)

@mback2k mback2k requested a review from bagder March 4, 2020 09:44
@mback2k mback2k self-assigned this Mar 4, 2020
@mback2k mback2k added tests Windows Windows-specific labels Mar 4, 2020
@mback2k mback2k marked this pull request as ready for review March 4, 2020 10:45
@mback2k
Copy link
Member Author

mback2k commented Mar 4, 2020

@bagder please review for Perl correctness, especially: https://github.com/curl/curl/pull/5035/files#diff-25e117efe4a0ebd947efbd1ecbe423a6R23-R30

@mback2k
Copy link
Member Author

mback2k commented Mar 4, 2020

All green CI, except the known issue with FreeBSD and the still pending travis-ci build.

@mback2k mback2k closed this in 9aaca09 Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

2 participants