tests: try to make sleeping portable by avoiding select#5035
Closed
mback2k wants to merge 1 commit intocurl:masterfrom
Closed
tests: try to make sleeping portable by avoiding select#5035mback2k wants to merge 1 commit intocurl:masterfrom
mback2k wants to merge 1 commit intocurl:masterfrom
Conversation
mback2k
force-pushed
the
fix-sleeping-in-testsuite
branch
2 times, most recently
from
1c9a3a1 to
10cb3dc
Compare
Member
Author
|
Cool side effect, this is speeding up even the Linux and MacOS CI builds by roughly 5 minutes. :-) |
select does not support just waiting on Windows: https://perldoc.perl.org/perlport.html#select
mback2k
force-pushed
the
fix-sleeping-in-testsuite
branch
from
10cb3dc to
93a1852
Compare
Member
Author
|
@bagder please review for Perl correctness, especially: https://github.com/curl/curl/pull/5035/files#diff-25e117efe4a0ebd947efbd1ecbe423a6R23-R30 |
Member
Author
|
All green CI, except the known issue with FreeBSD and the still pending travis-ci build. |
bagder
approved these changes
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
select does not support just waiting on Windows:
https://perldoc.perl.org/perlport.html#select
Another attempt to work on #5022 and #5034.