Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test 198 failing due to missing ftruncate on Windows #5055

Closed
wants to merge 2 commits into from

Conversation

@mback2k
Copy link
Member

@mback2k mback2k commented Mar 6, 2020

Extracted improvements from #5034.

mback2k added 2 commits Mar 6, 2020
This fixes test 198 on versions of MinGW-w64 without ftruncate
@mback2k mback2k self-assigned this Mar 6, 2020
@mback2k mback2k requested review from MarcelRaad and bagder Mar 6, 2020
@mback2k
Copy link
Member Author

@mback2k mback2k commented Mar 6, 2020

@bagder @MarcelRaad please take a look at the new way I am making it fallback to the custom ftruncate implementation if it is not available, regardless of MinGW-w64.

@bagder
bagder approved these changes Mar 6, 2020
@mback2k mback2k added the Windows label Mar 6, 2020
Copy link
Member

@MarcelRaad MarcelRaad left a comment

👍

@mback2k mback2k closed this in a39e5bf Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.