Skip to content

Fix test 198 failing due to missing ftruncate on Windows#5055

Closed
mback2k wants to merge 2 commits intocurl:masterfrom
mback2k:fix-test-198-mingw
Closed

Fix test 198 failing due to missing ftruncate on Windows#5055
mback2k wants to merge 2 commits intocurl:masterfrom
mback2k:fix-test-198-mingw

Conversation

@mback2k
Copy link
Member

@mback2k mback2k commented Mar 6, 2020

Extracted improvements from #5034.

@mback2k mback2k self-assigned this Mar 6, 2020
@mback2k mback2k requested review from MarcelRaad and bagder March 6, 2020 21:16
@mback2k
Copy link
Member Author

mback2k commented Mar 6, 2020

@bagder @MarcelRaad please take a look at the new way I am making it fallback to the custom ftruncate implementation if it is not available, regardless of MinGW-w64.

@mback2k mback2k added the Windows Windows-specific label Mar 6, 2020
Copy link
Member

@MarcelRaad MarcelRaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mback2k mback2k closed this in a39e5bf Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Windows Windows-specific

Development

Successfully merging this pull request may close these issues.

3 participants