Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: fix use of -isystem for system headers #5060

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

bagder commented Mar 8, 2020

No description provided.

@bagder bagder added the build label Mar 8, 2020
@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Mar 8, 2020

Hm, the c89 thing introduces a bunch of compiler warnings...

@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Mar 8, 2020

Most of them totally crazy too. 😞 I'll remove that and see if -isystem will be enough to fix for example the brotli header complaints.

As all the -I uses in CFLAGS at that point are for system headers and
third party libraries this helps us remove/ignore warnings on those!
@bagder bagder force-pushed the bagder/configure-compiler branch from 48e8aee to 39a5784 Mar 8, 2020
@bagder bagder changed the title configure: use -std=89 for debug and use -isystem for system headers configure: fix use of -isystem for system headers Mar 8, 2020
@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Mar 9, 2020

To play safe, I will merge this after 7.69.1 - since it does work-around the recent header warnings we've seen in 3rd party libs.

@bagder bagder closed this in 27ea8fc Mar 11, 2020
@bagder bagder deleted the bagder/configure-compiler branch Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.