Skip to content

configure: fix use of -isystem for system headers#5060

Closed
bagder wants to merge 1 commit intomasterfrom
bagder/configure-compiler
Closed

configure: fix use of -isystem for system headers#5060
bagder wants to merge 1 commit intomasterfrom
bagder/configure-compiler

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Mar 8, 2020

No description provided.

@bagder bagder added the build label Mar 8, 2020
@bagder
Copy link
Copy Markdown
Member Author

bagder commented Mar 8, 2020

Hm, the c89 thing introduces a bunch of compiler warnings...

@bagder
Copy link
Copy Markdown
Member Author

bagder commented Mar 8, 2020

Most of them totally crazy too. 😞 I'll remove that and see if -isystem will be enough to fix for example the brotli header complaints.

As all the -I uses in CFLAGS at that point are for system headers and
third party libraries this helps us remove/ignore warnings on those!
@bagder bagder force-pushed the bagder/configure-compiler branch from 48e8aee to 39a5784 Compare March 8, 2020 21:50
@bagder bagder changed the title configure: use -std=89 for debug and use -isystem for system headers configure: fix use of -isystem for system headers Mar 8, 2020
@bagder
Copy link
Copy Markdown
Member Author

bagder commented Mar 9, 2020

To play safe, I will merge this after 7.69.1 - since it does work-around the recent header warnings we've seen in 3rd party libs.

@bagder bagder closed this in 27ea8fc Mar 11, 2020
@bagder bagder deleted the bagder/configure-compiler branch March 11, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant