select: move duplicate select preparation code into Curl_select#5078
Closed
mback2k wants to merge 3 commits intocurl:masterfrom
Closed
select: move duplicate select preparation code into Curl_select#5078mback2k wants to merge 3 commits intocurl:masterfrom
mback2k wants to merge 3 commits intocurl:masterfrom
Conversation
mback2k
force-pushed
the
reuse-select-logic-once
branch
from
fc9d8e5 to
7944975
Compare
mback2k
force-pushed
the
reuse-select-logic-once
branch
from
7944975 to
74b157b
Compare
Member
Author
|
Once this PR has landed my plan is to do a follow-up and tidy-up the int vs. time_t for timeouts. |
Member
Author
|
Also the new Curl_select function could be used here then: Line 547 in 0845ecb |
MarcelRaad
approved these changes
Mar 14, 2020
Member
Author
|
@bagder please take a look at my approach and approve the changes if you accept them. |
bagder
approved these changes
Mar 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a re-used wrapper around select() to aid in Windows compatibility and timeout struct setup/preparation.