Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select: move duplicate select preparation code into Curl_select #5078

Closed
wants to merge 3 commits into from

Conversation

@mback2k
Copy link
Member

mback2k commented Mar 11, 2020

This introduces a re-used wrapper around select() to aid in Windows compatibility and timeout struct setup/preparation.

@mback2k mback2k force-pushed the mback2k:reuse-select-logic-once branch from fc9d8e5 to 7944975 Mar 11, 2020
@mback2k mback2k force-pushed the mback2k:reuse-select-logic-once branch from 7944975 to 74b157b Mar 11, 2020
@mback2k mback2k marked this pull request as ready for review Mar 11, 2020
@mback2k mback2k requested a review from bagder Mar 11, 2020
@mback2k mback2k self-assigned this Mar 11, 2020
@mback2k mback2k added the tidy-up label Mar 11, 2020
@mback2k

This comment has been minimized.

Copy link
Member Author

mback2k commented Mar 11, 2020

Once this PR has landed my plan is to do a follow-up and tidy-up the int vs. time_t for timeouts.

mback2k added 2 commits Mar 12, 2020
Detected by Codacy
@mback2k

This comment has been minimized.

Copy link
Member Author

mback2k commented Mar 14, 2020

Also the new Curl_select function could be used here then:

i = select(n + 1, &fds_read, &fds_write, NULL, &tv);

@mback2k

This comment has been minimized.

Copy link
Member Author

mback2k commented Mar 15, 2020

@bagder please take a look at my approach and approve the changes if you accept them.

@bagder
bagder approved these changes Mar 15, 2020
@mback2k mback2k closed this in c52b342 Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.