Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Debug sockfilt on Windows regarding waiting on stdin readability #5086

Closed
wants to merge 1 commit into from
Closed

[WIP] Debug sockfilt on Windows regarding waiting on stdin readability #5086

wants to merge 1 commit into from
+10 −1

Conversation

@mback2k
Copy link
Member

@mback2k mback2k commented Mar 12, 2020 •
edited

Related to #5034.
@mback2k mback2k self-assigned this Mar 12, 2020
@jay
jay reviewed Mar 12, 2020
View changes
tests/server/sockfilt.c Outdated Show resolved Hide resolved
@mback2k mback2k force-pushed the mback2k:debug-sockfilt branch from 9e5e5df to 5d8c6dd Mar 13, 2020
@mback2k mback2k mentioned this pull request Mar 13, 2020
Closed
@mback2k mback2k force-pushed the mback2k:debug-sockfilt branch from 5d8c6dd to 4338958 Mar 19, 2020
@mback2k
sockfilt: add logmsg output to select_ws_wait_thread on Windows
Verified
This commit was signed with a verified signature.
mback2k Marc Hörsken
GPG key ID: 61E03CBED7BC859E Learn about signing commits
Loading status checks…
8e57822
@mback2k mback2k force-pushed the mback2k:debug-sockfilt branch from 4338958 to 8e57822 Mar 24, 2020
@mback2k mback2k requested review from jay and bagder Mar 25, 2020
@mback2k mback2k marked this pull request as ready for review Mar 25, 2020
@mback2k
Copy link
Member Author

@mback2k mback2k commented Mar 25, 2020 •
edited

I would like to merge this PR now in order to allow easier debugging of the wait-on-stdin issues within our CIs. I think it does not hurt to have these logmsg's in Windows sockfilt for future debugging purposes.
@jay
jay approved these changes Mar 25, 2020
View changes
@bagder
bagder approved these changes Mar 25, 2020
View changes
@mback2k mback2k closed this in 6d45588 Mar 26, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder

@jay jay

Assignees

@mback2k mback2k

Labels
Windows tests
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@mback2k @bagder @jay