windows: suppress UI in all CryptAcquireContext() calls#5088
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
windows: suppress UI in all CryptAcquireContext() calls#5088vszakats wants to merge 1 commit intocurl:masterfrom
vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
Member
|
please put an area in the commit subject. for example in this case you could use all or windows or something generic since it appears to be all of the tool and lib also have you actually seen this happen |
vszakats
force-pushed
the
202003cryptsilent
branch
from
911cc28 to
154aa1e
Compare
vszakats
changed the title
Member
Author
|
@jay I've never personally seen a UI popping up. The flag was already used in some of the calls, and it's universally used in OpenSSL and other place. So, worst case, it's a "best practice". |
mback2k
approved these changes
Mar 13, 2020
Member
mback2k
left a comment
mback2k
left a comment
There was a problem hiding this comment.
I have seen this happen outside of curl in case 3rd-party crypto providers are installed, eg. for HSMs or other special purpose crypto hardware. Therefore I approve these changes as best practice measure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://docs.microsoft.com/windows/win32/api/wincrypt/nf-wincrypt-cryptacquirecontexta#parameters