Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: suppress UI in all CryptAcquireContext() calls #5088

Closed
wants to merge 1 commit into from

Conversation

@jay
Copy link
Member

@jay jay commented Mar 12, 2020

please put an area in the commit subject. for example in this case you could use all or windows or something generic since it appears to be all of the tool and lib

all: suppress UI in all CryptAcquireContext() calls

also have you actually seen this happen

@vszakats vszakats force-pushed the vszakats:202003cryptsilent branch from 911cc28 to 154aa1e Mar 12, 2020
@vszakats vszakats changed the title suppress UI in all CryptAcquireContext() calls windows: suppress UI in all CryptAcquireContext() calls Mar 12, 2020
@vszakats
Copy link
Member Author

@vszakats vszakats commented Mar 12, 2020

@jay I've never personally seen a UI popping up. The flag was already used in some of the calls, and it's universally used in OpenSSL and other place. So, worst case, it's a "best practice".

@mback2k mback2k self-requested a review Mar 13, 2020
Copy link
Member

@mback2k mback2k left a comment

I have seen this happen outside of curl in case 3rd-party crypto providers are installed, eg. for HSMs or other special purpose crypto hardware. Therefore I approve these changes as best practice measure.

@vszakats vszakats closed this in 7284061 Mar 17, 2020
@vszakats vszakats deleted the vszakats:202003cryptsilent branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.