tests: remove python_dependencies for smbserver from our tree#5094
tests: remove python_dependencies for smbserver from our tree#5094mback2k wants to merge 3 commits intocurl:masterfrom
Conversation
|
This PR will only covers the removal of our in-tree Python dependencies. For Python 3 another PR will follow. |
|
FWIW, FreeBSD has impacket in ports as py37-impacket.
|
This comment has been minimized.
This comment has been minimized.
|
@bagder test 323 is now failing in this PR, because I made stunnel available to the CI builds. But I do not have any clue why it is failing, would you mind taking a look at the failed Azure jobs? |
mback2k
force-pushed
the
remove-python-deps
branch
from
5453237 to
c44bc7d
Compare
|
@dfandrich for now I added |
mback2k
force-pushed
the
remove-python-deps
branch
from
c44bc7d to
86f6c73
Compare
|
I don't see any azure jobs at all? |
@bagder that is what I meant with "something is wrong with Azure CI not triggering for PRs anymore". After doing a force-push they weren't triggering anymore for some unknown reason. |
mback2k
force-pushed
the
remove-python-deps
branch
3 times, most recently
from
84e6f9e to
8ac64cd
Compare
This comment has been minimized.
This comment has been minimized.
|
Azure CI builds are for unknown reasons missing for this PR, but are looking good on my end. |
Users of the SMB tests will have to install impacket manually. Reasoning: our in-tree version of impacket was quite outdated and only compatible with Python 2 which is already end-of-life. Upgrading to Python 3 and a compatible impacket version would require to import additional Python-only and CPython-extension dependencies. This would have hindered portability enormously.
mback2k
force-pushed
the
remove-python-deps
branch
from
5e56138 to
79aa91e
Compare
mback2k
force-pushed
the
remove-python-deps
branch
from
79aa91e to
c5095fb
Compare
|
@dfandrich I will just add impacket to the FreeBSD builds in another PR to have this finished. |
|
Pending topics for follow up PRs:
|
MarcelRaad
left a comment
MarcelRaad
left a comment
There was a problem hiding this comment.
Also AppVeyor would be a candidate to install impacket later. We currently don't install any additional software there, but test 1451 is currently run and passing.
|
@MarcelRaad good idea, I guess it will make sense to include it in the WSL-based builds I am creating. For the other builds I am not sure how to install something in the Git bash.exe environment. |
4 participants
Users of the SMB tests will have to install impacket manually.
Reasoning: our in-tree version of impacket was quite outdated
and only compatible with Python 2 which is already end-of-life.
Upgrading to Python 3 and a compatible impacket version would
require to import additional Python-only and CPython-extension
dependencies. This would have hindered portability enormously.
See also #5085 for the previous discussion leading into this PR.