Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

ftp: attempt to fix EPSV over SOCKS bug #51

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

sapien2 commented Nov 12, 2012

libcurl can not correctly handle (i.e. switch to PASV) connection error while trying to establish connection in EPSV mode over SOCKS proxy.
https://sourceforge.net/tracker/?func=detail&aid=3586338&group_id=976&atid=100976

Owner

bagder commented Nov 12, 2012

I assume you have some means of testing this patch so you know it at least works for your case? The curl test suite unfortunately doesn't have a flexible enough SOCKS server to drive a proper test case for this setup.

Contributor

sapien2 commented Nov 13, 2012

I have tested it using direct connection, SOCKS4 and 5 proxies with and without authentication, with and without EPSV support on firewall, but only using curl executable.

Owner

bagder commented Nov 13, 2012

Thanks, your fix is now merged as commit 076e1fa.

@bagder bagder closed this Nov 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment