/ curl Public
http2: Fix erroneous debug message that h2 connection closed #5118
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Prior to this change in libcurl debug builds http2 stream closure was
erroneously referred to as connection closure.
curld -v https://httpbin.org/get https://httpbin.org/get
Curl_read calls the underlying read (http2_recv) which returns 0 when the stream is closed:
Lines 590 to 629 in b81e0b0
Lines 1730 to 1733 in b81e0b0
I don't understand that comment. When the stream is closed that does not mean the connection should be closed.