Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: remove the BACKEND define #5122

Closed
wants to merge 7 commits into from
Closed

tls: remove the BACKEND define #5122

wants to merge 7 commits into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented Mar 18, 2020

The use of #define BACKEND connssl->backend in the TLS backends is a discouraged way of writing code, it hides what's actually happening, it makes the code harder to follow and it makes it more complicated to work with using debuggers. Remove.

This PR does not remove the define from all backends, only from the ones I was able to build locally.

bagder added 6 commits Mar 18, 2020
Use a proper variable instead to make it easier to use a debugger and
read the code.
@bagder bagder closed this in cb2f57c Mar 19, 2020
@bagder bagder deleted the bagder/tls-backend-cleanup branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.