Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist: add mail-rcpt-allowfails.d to the tarball #5146

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented Mar 25, 2020

Reported-by: Maksim Stsepanenka

Reported-by: Maksim Stsepanenka
@jay
Copy link
Member

@jay jay commented Mar 25, 2020

commit message is missing a reference to the issue

@bagder
Copy link
Member Author

@bagder bagder commented Mar 25, 2020

There is no public issue to refer to. I got it privately.

@jay
jay approved these changes Mar 25, 2020
bagder added a commit that referenced this pull request Mar 25, 2020
The idea being that all *.d files should be present in the DPAGES
variable in Makefile.inc as otherwise they're missing in the dist.

This makefile target is not used anywhere (yet) but should possibly be
added to a CI job or similar.

Ref: #5146
@bagder bagder closed this in 3531821 Mar 25, 2020
@bagder bagder deleted the bagder/missing-mail-rcpt-allowfails branch Mar 25, 2020
bagder added a commit that referenced this pull request Mar 26, 2020
Previously it rendered the page from files matching "*.d" in the correct
directory, which worked fine in git builds when the files were added but
made it easy to forget adding the files to the dist.

Now, only man page sections listed in DPAGES in Makefile.inc will be
used, thus "forcing" us to update this to get the man page right and get
it included in the dist at the same time.

Ref: #5146
bagder added a commit that referenced this pull request Mar 26, 2020
Previously it rendered the page from files matching "*.d" in the correct
directory, which worked fine in git builds when the files were added but
made it easy to forget adding the files to the dist.

Now, only man page sections listed in DPAGES in Makefile.inc will be
used, thus "forcing" us to update this to get the man page right and get
it included in the dist at the same time.

Ref: #5146
Closes #5149
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.