vquic: add support for GnuTLS backend of ngtcp2#5148
Closed
ueno wants to merge 2 commits intocurl:masterfrom
Closed
vquic: add support for GnuTLS backend of ngtcp2#5148ueno wants to merge 2 commits intocurl:masterfrom
ueno wants to merge 2 commits intocurl:masterfrom
Conversation
Member
|
Lovely! Can you also update Do you have any ideas or guesses on when we can hope for this work to be merged into the master branches of GnuTLS and ngtcp2? It think it also makes sense to create a CI job that verifies the build, in the same spirit as the existing ngtcp2-openssl build is done. We can of course do that as a second follow-up PR. |
Contributor
|
I just merged GnuTLS support into ngtcp2. |
Contributor
Author
|
Thank you; updated the patches with the suggested changes. |
Member
Contributor
Author
|
Sure, filed a separate PR as #5168. |
Currently, the TLS backend used by vquic/ngtcp2.c is selected at compile time. Therefore OpenSSL support needs to be explicitly disabled. Signed-off-by: Daiki Ueno <dueno@redhat.com>
f692bb8 to
ded8586
Compare
Contributor
Author
|
The build in Travis CI seems to have succeeded (finally): https://travis-ci.org/github/curl/curl/jobs/669087295 |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be built with the same steps as the ngtcp2 + OpenSSL procedure mentioned in
docs/HTTP3.md, except:tmp-quicbranch) needs to be installed instead--with-gnutlsinstead of--with-sslCurrently, the TLS backend used by
vquic/ngtcp2.cis selected at compile time. Therefore OpenSSL support needs to be explicitly disabled.