Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checksrc: warn for "onelinecondition" #5164

Closed
wants to merge 2 commits into from

Conversation

@bagder
Copy link
Member

bagder commented Mar 30, 2020

Make checksrc verify that we insert newline after if() conditions and fix a few places where this updated checksrc pointed out this mistake to exist in.

The check is a little naive and will only work for single-line conditions but I think they are the most common for this code style anyway.

@bagder bagder added the tidy-up label Mar 30, 2020
bagder added 2 commits Mar 30, 2020
Our code style mandates we put the conditional block on a separate
line. These mistakes were detected by the updated checksrc.
@bagder bagder force-pushed the bagder/checksrc-onelinecondition branch from 4277a29 to e7f0c31 Mar 30, 2020
@bagder bagder closed this in 529add4 Mar 30, 2020
@bagder bagder deleted the bagder/checksrc-onelinecondition branch Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.