checksrc: warn for "onelinecondition" #5164
Closed
Conversation
Our code style mandates we put the conditional block on a separate line. These mistakes were detected by the updated checksrc.
bagder
force-pushed the
bagder/checksrc-onelinecondition
branch
from
4277a29
to
e7f0c31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Make checksrc verify that we insert newline after if() conditions and fix a few places where this updated checksrc pointed out this mistake to exist in.
The check is a little naive and will only work for single-line conditions but I think they are the most common for this code style anyway.