Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for Security.framework when cross-compiling #5189

Closed
wants to merge 1 commit into from

Conversation

@def-
Copy link
Contributor

@def- def- commented Apr 6, 2020

Since it probably won't exist.

@bagder bagder added the build label Apr 6, 2020
@bagder
Copy link
Member

@bagder bagder commented Apr 6, 2020

Isn't the reason rather that it checks for the local file and not for the cross-compiled version so the check is wrong?

Loading

@def-
Copy link
Contributor Author

@def- def- commented Apr 6, 2020

Correct. Is there a better way to check?

Loading

@bagder
Copy link
Member

@bagder bagder commented Apr 6, 2020

I have no idea, @nickzman, do you know of if that can be done better?

My comment was more in regards to the commit message here, as reading the patch it seems correct but I found the explanation a little off.

Loading

Since it checks for the local file, not the cross-compiled one.
@def- def- force-pushed the pr-security-framework branch from c47500c to 52a86da Apr 6, 2020
@def-
Copy link
Contributor Author

@def- def- commented Apr 6, 2020

Fixed the commit message.

Loading

bagder
bagder approved these changes Apr 6, 2020
@bagder bagder closed this in 2ebc123 Apr 6, 2020
@bagder
Copy link
Member

@bagder bagder commented Apr 6, 2020

Thanks!

Loading

@def- def- deleted the pr-security-framework branch Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants