Don't check for Security.framework when cross-compiling #5189
Conversation
|
Isn't the reason rather that it checks for the local file and not for the cross-compiled version so the check is wrong? |
|
Correct. Is there a better way to check? |
|
I have no idea, @nickzman, do you know of if that can be done better? My comment was more in regards to the commit message here, as reading the patch it seems correct but I found the explanation a little off. |
Since it checks for the local file, not the cross-compiled one.
|
Fixed the commit message. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Since it probably won't exist.