Skip to content

support .P12 or .PFX certificat client file with MS-Windows Schannel - #5193

Closed
gvollant wants to merge 1 commit into
curl:masterfrom
gvollant:winschannel/certp12filewin
Closed

support .P12 or .PFX certificat client file with MS-Windows Schannel#5193
gvollant wants to merge 1 commit into
curl:masterfrom
gvollant:winschannel/certp12filewin

Conversation

@gvollant

@gvollant gvollant commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

this branch add support .P12 or .PFX certificat client file with curl compiled against MS-Windows Schannel
to be used with curl command line option: --cert : --cert-type p12

@gvollant
support .P12 or .PFX certificat client file with MS-Windows Schannel
2d99efc 
to be used with curl command line option: --cert <filename>:<password> --cert-type p12
@bagder bagder added the TLS label Apr 6, 2020
@mback2k mback2k mentioned this pull request Apr 7, 2020
Closed
bagder
bagder approved these changes Apr 8, 2020
View reviewed changes

@bagder bagder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The red appveyor build is not your fault...

@bagder

bagder commented Apr 8, 2020

Copy link
Copy Markdown
Member

Thanks!

@bagder bagder closed this in 0fdf965 Apr 8, 2020
@gvollant

gvollant commented Apr 8, 2020

Copy link
Copy Markdown
Contributor Author

do you known why this PR is closed?

@bagder

bagder commented Apr 8, 2020

Copy link
Copy Markdown
Member

"@bagder closed this in 0fdf965 14 minutes ago " <= means that it was closed due to an instruction in a commit that was merged into curl. That's github's quirky way of saying it was merged but not merged via github.

@gvollant
gvollant deleted the winschannel/certp12filewin branch April 8, 2020 12:55
@gvollant

gvollant commented Apr 10, 2020

Copy link
Copy Markdown
Contributor Author

this was same code in #4356 , but this old PR was closed without merge

@bagder

bagder commented Apr 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

you closed #4356

gvollant closed this on Sep 22, 2019

@gvollant

gvollant commented Apr 10, 2020

Copy link
Copy Markdown
Contributor Author

yes. But I think it is useful have a link between discussion for archive

@vszakats vszakats mentioned this pull request Jul 28, 2026
Closed
vszakats added a commit that referenced this pull request Jul 28, 2026
@vszakats
schannel: fix error check logic in get_client_cert() file reader
1386135 
Reported by GitHub Code Quality
Follow-up to 0fdf965 #5193

Closes #22415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bagder bagder bagder approved these changes

Assignees

No one assigned

Labels

TLS

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gvollant @bagder