Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support .P12 or .PFX certificat client file with MS-Windows Schannel #5193

Closed
wants to merge 1 commit into from

Conversation

@gvollant
Copy link
Contributor

gvollant commented Apr 6, 2020

this branch add support .P12 or .PFX certificat client file with curl compiled against MS-Windows Schannel
to be used with curl command line option: --cert : --cert-type p12

to be used with curl command line option: --cert <filename>:<password> --cert-type p12
@bagder
bagder approved these changes Apr 8, 2020
Copy link
Member

bagder left a comment

The red appveyor build is not your fault...

@bagder
Copy link
Member

bagder commented Apr 8, 2020

Thanks!

@bagder bagder closed this in 0fdf965 Apr 8, 2020
@gvollant
Copy link
Contributor Author

gvollant commented Apr 8, 2020

do you known why this PR is closed?

@bagder
Copy link
Member

bagder commented Apr 8, 2020

"@bagder closed this in 0fdf965 14 minutes ago " <= means that it was closed due to an instruction in a commit that was merged into curl. That's github's quirky way of saying it was merged but not merged via github.

@gvollant gvollant deleted the gvollant:winschannel/certp12filewin branch Apr 8, 2020
@gvollant
Copy link
Contributor Author

gvollant commented Apr 10, 2020

this was same code in #4356 , but this old PR was closed without merge

@bagder
Copy link
Member

bagder commented Apr 10, 2020

you closed #4356

gvollant closed this on Sep 22, 2019

@gvollant
Copy link
Contributor Author

gvollant commented Apr 10, 2020

yes. But I think it is useful have a link between discussion for archive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.