test1148: tolerate progress updates better (again)#5194
Closed
jay wants to merge 1 commit intocurl:masterfrom
Closed
test1148: tolerate progress updates better (again)#5194jay wants to merge 1 commit intocurl:masterfrom
jay wants to merge 1 commit intocurl:masterfrom
Conversation
- Ignore intermediate progress updates. - Support locales that use a character other than period as decimal separator (eg 100,0%). test1148 checks that the progress finishes at 100% and has the right bar width. Prior to this change the test assumed that the only progress reported for such a quick transfer was 100%, however in rare instances (like in the CI where transfer time can slow considerably) there may be intermediate updates. For example, below is stderrlog1148 from a failed CI run with explicit \r and \n added (it is one line; broken up so that it's easier to understand). \r \r################################## 48.3% \r######################################################################## 100.0% \n Closes #xxxx
MarcelRaad
approved these changes
Apr 7, 2020
Member
MarcelRaad
left a comment
There was a problem hiding this comment.
👍
Why didn't I just to it this way in #2786? I think you can also remove the chkdecimalpoint stuff now.
bagder
approved these changes
Apr 7, 2020
bagder
approved these changes
Apr 8, 2020
Member
|
Hm, I could apparently approve it twice! 😁 |
1 task
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jul 22, 2025
No longer necessary after a previous change made sure to strip the '100.0%' number from the result, before checking it. The dot is a regex character catching any decimal character. Follow-up to 17c18fb curl#5194 Ref: curl#2436 Cherry-picked from curl#17988
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore intermediate progress updates.
Support locales that use a character other than period as decimal
separator (eg 100,0%).
test1148 checks that the progress finishes at 100% and has the right
bar width. Prior to this change the test assumed that the only progress
reported for such a quick transfer was 100%, however in rare instances
(like in the CI where transfer time can slow considerably) there may be
intermediate updates. For example, below is stderrlog1148 from a failed
CI run with explicit \r and \n added (it is one line; broken up so that
it's easier to understand).
Closes #xxxx
The improvements made in 6cbe969 (#2488) didn't go far enough.
CI failure: https://github.com/jay/curl/runs/565278274#step:6:2297
To reproduce: