tests: pick a random port number for SSH #5273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
force-pushed
the
bagder/tests-ssh-randomport
branch
from
67a6ab7
to
e925814
Compare
Since sshd doesn't have such an option by itself, we iterate over a series of random ports until one works. Closes #5273
bagder
force-pushed
the
bagder/tests-ssh-randomport
branch
from
e925814
to
ec1442d
Compare
|
When trying out this method, I spotted that it doesn't work on Cirrus-CI. I then went back and noticed that the SSH server was never started/used fine on Cirrus so this isn't new with this PR. The reason seems to be that the "verification" of the server with the sftp command fails. This is the hint in the sftp server log: According to sources "on the internet" this (the "message too long") is typically the result of the user having |
|
Please give me a chance to test this locally on Windows before merging. I will try to do that now. |
|
I haven't got the SSH tests working on Windows again yet, regardless of this PR. I will retry tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Since sshd doesn't have such an option by itself, we iterate over a
series of random ports until one works.