Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: pick a random port number for SSH #5273

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented Apr 20, 2020

Since sshd doesn't have such an option by itself, we iterate over a
series of random ports until one works.

Since sshd doesn't have such an option by itself, we iterate over a
series of random ports until one works.

Closes #5273
@bagder bagder force-pushed the bagder/tests-ssh-randomport branch from e925814 to ec1442d Apr 21, 2020
@bagder
Copy link
Member Author

@bagder bagder commented Apr 21, 2020

When trying out this method, I spotted that it doesn't work on Cirrus-CI. I then went back and noticed that the SSH server was never started/used fine on Cirrus so this isn't new with this PR. The reason seems to be that the "verification" of the server with the sftp command fails. This is the hint in the sftp server log:

debug2: channel_input_status_confirm: type 99 id 0
debug2: subsystem request accepted on channel 0
Received message too long 1416128883

According to sources "on the internet" this (the "message too long") is typically the result of the user having /sbin/nologin or similar as shell in /etc/passwd.

@mback2k mback2k self-requested a review Apr 21, 2020
@mback2k
Copy link
Member

@mback2k mback2k commented Apr 21, 2020

Please give me a chance to test this locally on Windows before merging. I will try to do that now.

@mback2k
Copy link
Member

@mback2k mback2k commented Apr 21, 2020

I haven't got the SSH tests working on Windows again yet, regardless of this PR. I will retry tomorrow.

Copy link
Member

@mback2k mback2k left a comment

This is passing my local tests on Windows 👍 (after #5298 was applied)

@bagder
Copy link
Member Author

@bagder bagder commented Apr 26, 2020

Awesome, thanks @mback2k! I'll merge this and the stunnel fix (#5267) after the pending release.

@bagder bagder self-assigned this Apr 26, 2020
@bagder bagder closed this in d1239b5 Apr 30, 2020
@bagder bagder deleted the bagder/tests-ssh-randomport branch Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.