tests: make runtests check that disabled tests exists#5288
Closed
tests: make runtests check that disabled tests exists#5288
Conversation
... and error out if so. Removed '536' from DISABLED as there is no such test file.
Member
|
Hmm, not for the autobuilds at least. Every single autobuild is failing with "WARNING! Non-exiting test 594 in DISABLED!". But data/test594 does exist... 😕 |
Contributor
|
I only tried executing runtests.pl inside the tests directory. It probably assumes that $PWD is in the tests folder |
Member
Author
|
I suspect @emilengler is right. I'll dig in soon. |
Contributor
|
Another thing that supports my theory is that running make test on my system sets $srcdir to where as Travis does In my envrionment EDIT: Oh no wait, it actually points to the test dir -.- |
bagder
added a commit
that referenced
this pull request
Apr 25, 2020
To make it work correctly for out-of-tree builds. Follow-up to 75e8feb Bug: #5288 (comment) Reported-by: Marcel Raad Closes #5297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and error out if so. Removed '536' from DISABLED as there is no such
test file.