Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make runtests check that disabled tests exists #5288

Closed
wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

bagder commented Apr 24, 2020

... and error out if so. Removed '536' from DISABLED as there is no such
test file.

... and error out if so. Removed '536' from DISABLED as there is no such
test file.
@bagder bagder added the tests label Apr 24, 2020
Copy link
Contributor

emilengler left a comment

Tested and works!

@bagder bagder closed this in 75e8feb Apr 24, 2020
@bagder bagder deleted the bagder/tests-verify-disabled branch Apr 24, 2020
@MarcelRaad
Copy link
Member

MarcelRaad commented Apr 25, 2020

Hmm, not for the autobuilds at least. Every single autobuild is failing with "WARNING! Non-exiting test 594 in DISABLED!". But data/test594 does exist... 😕
Maybe it looks in the wrong directory depending on where it's called from?

@emilengler
Copy link
Contributor

emilengler commented Apr 25, 2020

I only tried executing runtests.pl inside the tests directory. It probably assumes that $PWD is in the tests folder

@bagder
Copy link
Member Author

bagder commented Apr 25, 2020

I suspect @emilengler is right. I'll dig in soon.

@emilengler
Copy link
Contributor

emilengler commented Apr 25, 2020

Another thing that supports my theory is that running make test on my system sets $srcdir to

srcdir=. /usr/bin/perl -I. ./runtests.pl -a -s 

where as Travis does

srcdir=../../curl-99.98.97/tests /usr/bin/perl -I../../curl-99.98.97/tests ../../curl-99.98.97/tests/runtests.pl -a -s -p 1 1139

In my envrionment . points to the repo root. I verified this by printing out my @files = glob($srcdir . '/*');

EDIT: Oh no wait, it actually points to the test dir -.-

bagder added a commit that referenced this pull request Apr 25, 2020
To make it work correctly for out-of-tree builds.

Follow-up to 75e8feb

Bug: #5288 (comment)
Reported-by: Marcel Raad
Closes #5297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.