Skip to content

tests: add support for SSH server variant specific transfer paths #5298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mback2k
Copy link
Member

@mback2k mback2k commented Apr 26, 2020

OpenSSH for Windows requires paths in the format of /C:/
instead of the pseudo-POSIX paths /cygdrive/c/ or just /c/

Discovered while testing #5273.

OpenSSH for Windows requires paths in the format of /C:/
instead of the pseudo-POSIX paths /cygdrive/c/ or just /c/
@mback2k mback2k requested a review from bagder April 26, 2020 16:33
@mback2k mback2k self-assigned this Apr 26, 2020
@mback2k mback2k added the tests label Apr 26, 2020
@mback2k mback2k added the feature-window A merge of this requires an open feature window label Apr 27, 2020
@bagder
Copy link
Member

bagder commented Apr 29, 2020

Does it matter if we land this or #5273 first?

@mback2k
Copy link
Member Author

mback2k commented Apr 29, 2020

Does it matter if we land this or #5273 first?

Nope, I will land this together with my other PRs, probably during the weekend or in the evening.

@mback2k mback2k closed this in 1abb087 May 2, 2020
vszakats added a commit to vszakats/curl that referenced this pull request Mar 23, 2025
vszakats added a commit to vszakats/curl that referenced this pull request Mar 23, 2025
vszakats added a commit to vszakats/curl that referenced this pull request Mar 24, 2025
vszakats added a commit to vszakats/curl that referenced this pull request Mar 26, 2025
vszakats added a commit to vszakats/curl that referenced this pull request Apr 4, 2025
vszakats added a commit to vszakats/curl that referenced this pull request Apr 12, 2025
vszakats added a commit to vszakats/curl that referenced this pull request Apr 12, 2025
This allows to use a different for format than for `sftp://`.

Follow-up to 1abb087 curl#5298
vszakats added a commit to vszakats/curl that referenced this pull request Apr 13, 2025
This allows to use a different for format than for `sftp://`.

Follow-up to 1abb087 curl#5298
vszakats added a commit to vszakats/curl that referenced this pull request Apr 13, 2025
This allows to use a different for format than for `sftp://`.

Follow-up to 1abb087 curl#5298
vszakats added a commit that referenced this pull request Apr 14, 2025
To allow configuring paths styles for SCP and SFTP servers separately.

- make `scp://` URLs use `%SCP_PWD` (was: `%SSH_PWD`).
- make `%SCP_PWD` equal to `%POSIX_PWD`.
  To fix test 3022 with OpenSSH-Windows 9.8.0 server.
  The fix works on a local machine. Remains broken in CI.
  Before this patch, it was equal to `%FILE_PWD` when using
  OpenSSH-Windows, otherwise it was `%POSIX_PWD`.
  Notice that no matter what path-style we pass, test 3022
  was and still is broken with earlier OpenSSH-Windows versions.
  (as tested with 9.5.0, 9.5.0-beta20240403, 8.0.0.1)
- rename rest of `%SSH_PWD` uses to `%SFTP_PWD`.
- drop unused `%POSIX_PWD`.
- GHA/windows: test with OpenSSH-Windows server again.
  In the LibreSSL MSVC job. This job is short enough to fit the slow
  install of the built-in OpenSSH-Windows tools, if needed.

Follow-up to 1abb087 #5298
Ref: #16803
Closes #17041
nbaws pushed a commit to nbaws/curl that referenced this pull request Apr 26, 2025
To allow configuring paths styles for SCP and SFTP servers separately.

- make `scp://` URLs use `%SCP_PWD` (was: `%SSH_PWD`).
- make `%SCP_PWD` equal to `%POSIX_PWD`.
  To fix test 3022 with OpenSSH-Windows 9.8.0 server.
  The fix works on a local machine. Remains broken in CI.
  Before this patch, it was equal to `%FILE_PWD` when using
  OpenSSH-Windows, otherwise it was `%POSIX_PWD`.
  Notice that no matter what path-style we pass, test 3022
  was and still is broken with earlier OpenSSH-Windows versions.
  (as tested with 9.5.0, 9.5.0-beta20240403, 8.0.0.1)
- rename rest of `%SSH_PWD` uses to `%SFTP_PWD`.
- drop unused `%POSIX_PWD`.
- GHA/windows: test with OpenSSH-Windows server again.
  In the LibreSSL MSVC job. This job is short enough to fit the slow
  install of the built-in OpenSSH-Windows tools, if needed.

Follow-up to 1abb087 curl#5298
Ref: curl#16803
Closes curl#17041
nbaws pushed a commit to nbaws/curl that referenced this pull request Apr 26, 2025
To allow configuring paths styles for SCP and SFTP servers separately.

- make `scp://` URLs use `%SCP_PWD` (was: `%SSH_PWD`).
- make `%SCP_PWD` equal to `%POSIX_PWD`.
  To fix test 3022 with OpenSSH-Windows 9.8.0 server.
  The fix works on a local machine. Remains broken in CI.
  Before this patch, it was equal to `%FILE_PWD` when using
  OpenSSH-Windows, otherwise it was `%POSIX_PWD`.
  Notice that no matter what path-style we pass, test 3022
  was and still is broken with earlier OpenSSH-Windows versions.
  (as tested with 9.5.0, 9.5.0-beta20240403, 8.0.0.1)
- rename rest of `%SSH_PWD` uses to `%SFTP_PWD`.
- drop unused `%POSIX_PWD`.
- GHA/windows: test with OpenSSH-Windows server again.
  In the LibreSSL MSVC job. This job is short enough to fit the slow
  install of the built-in OpenSSH-Windows tools, if needed.

Follow-up to 1abb087 curl#5298
Ref: curl#16803
Closes curl#17041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-window A merge of this requires an open feature window tests
Development

Successfully merging this pull request may close these issues.

2 participants