tests: add support for SSH server variant specific transfer paths #5298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSH for Windows requires paths in the format of /C:/ instead of the pseudo-POSIX paths /cygdrive/c/ or just /c/
bagder
approved these changes
Apr 26, 2020
|
Does it matter if we land this or #5273 first? |
Nope, I will land this together with my other PRs, probably during the weekend or in the evening. |
vszakats
added a commit
that referenced
this pull request
Apr 14, 2025
To allow configuring paths styles for SCP and SFTP servers separately. - make `scp://` URLs use `%SCP_PWD` (was: `%SSH_PWD`). - make `%SCP_PWD` equal to `%POSIX_PWD`. To fix test 3022 with OpenSSH-Windows 9.8.0 server. The fix works on a local machine. Remains broken in CI. Before this patch, it was equal to `%FILE_PWD` when using OpenSSH-Windows, otherwise it was `%POSIX_PWD`. Notice that no matter what path-style we pass, test 3022 was and still is broken with earlier OpenSSH-Windows versions. (as tested with 9.5.0, 9.5.0-beta20240403, 8.0.0.1) - rename rest of `%SSH_PWD` uses to `%SFTP_PWD`. - drop unused `%POSIX_PWD`. - GHA/windows: test with OpenSSH-Windows server again. In the LibreSSL MSVC job. This job is short enough to fit the slow install of the built-in OpenSSH-Windows tools, if needed. Follow-up to 1abb087 #5298 Ref: #16803 Closes #17041
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
To allow configuring paths styles for SCP and SFTP servers separately. - make `scp://` URLs use `%SCP_PWD` (was: `%SSH_PWD`). - make `%SCP_PWD` equal to `%POSIX_PWD`. To fix test 3022 with OpenSSH-Windows 9.8.0 server. The fix works on a local machine. Remains broken in CI. Before this patch, it was equal to `%FILE_PWD` when using OpenSSH-Windows, otherwise it was `%POSIX_PWD`. Notice that no matter what path-style we pass, test 3022 was and still is broken with earlier OpenSSH-Windows versions. (as tested with 9.5.0, 9.5.0-beta20240403, 8.0.0.1) - rename rest of `%SSH_PWD` uses to `%SFTP_PWD`. - drop unused `%POSIX_PWD`. - GHA/windows: test with OpenSSH-Windows server again. In the LibreSSL MSVC job. This job is short enough to fit the slow install of the built-in OpenSSH-Windows tools, if needed. Follow-up to 1abb087 curl#5298 Ref: curl#16803 Closes curl#17041
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
To allow configuring paths styles for SCP and SFTP servers separately. - make `scp://` URLs use `%SCP_PWD` (was: `%SSH_PWD`). - make `%SCP_PWD` equal to `%POSIX_PWD`. To fix test 3022 with OpenSSH-Windows 9.8.0 server. The fix works on a local machine. Remains broken in CI. Before this patch, it was equal to `%FILE_PWD` when using OpenSSH-Windows, otherwise it was `%POSIX_PWD`. Notice that no matter what path-style we pass, test 3022 was and still is broken with earlier OpenSSH-Windows versions. (as tested with 9.5.0, 9.5.0-beta20240403, 8.0.0.1) - rename rest of `%SSH_PWD` uses to `%SFTP_PWD`. - drop unused `%POSIX_PWD`. - GHA/windows: test with OpenSSH-Windows server again. In the LibreSSL MSVC job. This job is short enough to fit the slow install of the built-in OpenSSH-Windows tools, if needed. Follow-up to 1abb087 curl#5298 Ref: curl#16803 Closes curl#17041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSH for Windows requires paths in the format of
/C:/instead of the pseudo-POSIX paths
/cygdrive/c/or just/c/Discovered while testing #5273.