Skip to content

make test-suite work with separate build dir - #5310

Closed
kdudka wants to merge 2 commits into
curl:masterfrom
kdudka:separate-build-dir
Closed

make test-suite work with separate build dir#5310
kdudka wants to merge 2 commits into
curl:masterfrom
kdudka:separate-build-dir

Conversation

@kdudka

@kdudka kdudka commented Apr 29, 2020

Copy link
Copy Markdown
Contributor

No description provided.

kdudka added 2 commits April 29, 2020 13:26
... which is not always the same directory as source directory
If we use a separate build directory, there is no copy of the header.

@MarcelRaad MarcelRaad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's the reason why there is no single green autobuild on https://curl.haxx.se/dev/builds.html? I just wanted to start looking into this :-)

@kdudka

kdudka commented Apr 29, 2020

Copy link
Copy Markdown
Contributor Author

Reproducer:

curl -L https://curl.haxx.se/download/curl-7.70.0.tar.xz | xz -cd | tar -xv
mkdir curl-7.70.0/build
cd curl-7.70.0/build
../configure
make check

@kdudka

kdudka commented Apr 29, 2020

Copy link
Copy Markdown
Contributor Author

@MarcelRaad Thanks for review! That was fast :-)

@kdudka kdudka closed this in 1066f5f Apr 29, 2020
kdudka added a commit that referenced this pull request Apr 29, 2020
If we use a separate build directory, there is no copy of the header.

Closes #5310
@kdudka
kdudka deleted the separate-build-dir branch April 29, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants