make test-suite work with separate build dir #5310

kdudka · 2020-04-29T11:31:17Z

No description provided.

... which is not always the same directory as source directory

If we use a separate build directory, there is no copy of the header.

MarcelRaad

Ah, that's the reason why there is no single green autobuild on https://curl.haxx.se/dev/builds.html? I just wanted to start looking into this :-)

kdudka · 2020-04-29T11:39:54Z

Reproducer:

curl -L https://curl.haxx.se/download/curl-7.70.0.tar.xz | xz -cd | tar -xv
mkdir curl-7.70.0/build
cd curl-7.70.0/build
../configure
make check

kdudka · 2020-04-29T11:50:26Z

@MarcelRaad Thanks for review! That was fast :-)

If we use a separate build directory, there is no copy of the header. Closes #5310

kdudka added 2 commits April 29, 2020 13:26

tests: look for preprocessed tests in build directory

5a59b4e

... which is not always the same directory as source directory

test1177: look for curl.h in source directory

d4c1afa

If we use a separate build directory, there is no copy of the header.

MarcelRaad approved these changes Apr 29, 2020

View reviewed changes

kdudka closed this in 1066f5f Apr 29, 2020

kdudka added a commit that referenced this pull request Apr 29, 2020

test1177: look for curl.h in source directory

68774da

If we use a separate build directory, there is no copy of the header. Closes #5310

kdudka deleted the separate-build-dir branch April 29, 2020 12:42

make test-suite work with separate build dir #5310

make test-suite work with separate build dir #5310

kdudka commented Apr 29, 2020

MarcelRaad left a comment

kdudka commented Apr 29, 2020

kdudka commented Apr 29, 2020

make test-suite work with separate build dir #5310

make test-suite work with separate build dir #5310

Conversation

kdudka commented Apr 29, 2020

MarcelRaad left a comment

Choose a reason for hiding this comment

kdudka commented Apr 29, 2020

kdudka commented Apr 29, 2020