Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make test-suite work with separate build dir #5310

Closed
wants to merge 2 commits into from
Closed

make test-suite work with separate build dir #5310

wants to merge 2 commits into from

Conversation

@kdudka
Copy link
Collaborator

@kdudka kdudka commented Apr 29, 2020

No description provided.

kdudka added 2 commits Apr 29, 2020
@kdudka
tests: look for preprocessed tests in build directory
5a59b4e 
... which is not always the same directory as source directory
@kdudka
test1177: look for curl.h in source directory
Loading status checks…
d4c1afa 
If we use a separate build directory, there is no copy of the header.
@MarcelRaad
MarcelRaad approved these changes Apr 29, 2020
View changes
Copy link
Member

@MarcelRaad MarcelRaad left a comment

Ah, that's the reason why there is no single green autobuild on https://curl.haxx.se/dev/builds.html? I just wanted to start looking into this :-)
@kdudka
Copy link
Collaborator Author

@kdudka kdudka commented Apr 29, 2020

Reproducer:

curl -L https://curl.haxx.se/download/curl-7.70.0.tar.xz | xz -cd | tar -xv
mkdir curl-7.70.0/build
cd curl-7.70.0/build
../configure
make check
@kdudka
Copy link
Collaborator Author

@kdudka kdudka commented Apr 29, 2020

@MarcelRaad Thanks for review! That was fast :-)
@kdudka kdudka closed this in 1066f5f Apr 29, 2020
kdudka added a commit that referenced this pull request Apr 29, 2020
@kdudka
test1177: look for curl.h in source directory
Loading status checks…
68774da 
If we use a separate build directory, there is no copy of the header.

Closes #5310
@kdudka kdudka deleted the kdudka:separate-build-dir branch Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelRaad MarcelRaad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@kdudka @MarcelRaad