Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theoretical integer overflow in Curl_auth_create_plain_message #5391

Closed
wants to merge 1 commit into from
Closed

Fix theoretical integer overflow in Curl_auth_create_plain_message #5391

wants to merge 1 commit into from

Conversation

@MajorTomSec
Copy link
Contributor

@MajorTomSec MajorTomSec commented May 13, 2020

This PR fixes an incorrect integer overflow check in Curl_auth_create_plain_message.

The security impact of the potential integer overflow has been discussed with @bagder on hackerone. We agreed this is more of a theoretical vulnerability, as the integer overflow would only be triggerable on systems using 32-bits size_t and have over 4GB of available memory space.

We still thought this was worth fixing.

Fix theoretical integer overflow in Curl_auth_create_plain_message.
bagder
bagder approved these changes May 13, 2020
@bagder bagder closed this in 8e76219 May 14, 2020
@bagder
Copy link
Member

@bagder bagder commented May 14, 2020

Thanks!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants