[CMakeLists.txt] Remove explicit CMAKE_ANSI_CFLAGS

[SamuelMarks]

Hadn't seen the CMAKE_ANSI_CFLAGS flag before, searched it and found: https://gitlab.kitware.com/cmake/cmake/commit/5a834b0bb0bc2889bb67bdaac37ce9b17d4f0f59

[bagder]

Can you please clarify why you want to remove this and what effects it will have on users on new and old cmake verisons? That link didn't help me.

[SamuelMarks]

That link makes me think that this approach has been redundant for 12 years…

[Lekensteyn]

I can confirm that that variable was removed in the referenced commit. A later CMake commit removes the variable from the tests, claiming that it was removed in CMake 2.6. With an updated commit message that clarifies why it is safe (a reference to the CMake commit) to remove I think it is good to take it.

I am curious though how you ran into this piece of code?

[SamuelMarks]

@Lekensteyn Great!

Oh, I just searched for CMAKE_ANSI_CFLAGS when I was reviewing libcurl's way of doing things in its CMakeLists.txt (for my own projects, I'm adding support for different crypto libraries, HTTP & HTTPS libraries, &etc.).

[bagder]

@Lekensteyn is that an ack from you to merge this?

[Lekensteyn]

Yes sure, the patch looks fine. I would suggest updating the commit message to make clear why it is safe to remove this, but it looks fine otherwise.

[bagder]

Thanks!