build: disable more code/data when built without proxy support - #5466
Closed
bagder wants to merge 1 commit into
Closed
build: disable more code/data when built without proxy support#5466bagder wants to merge 1 commit into
bagder wants to merge 1 commit into
Conversation
Added build to travis to verify
bagder
force-pushed
the
bagder/strip-more-disabled-proxy
branch
from
May 29, 2020 21:36
35d9356 to
1801bdb
Compare
bagder
added a commit
that referenced
this pull request
Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom builds like this are primarily done by special use cases, for example smaller embedded devices when they know they don't need a specific feature and they want as small foot-print as possible. When we provide a way to disable features at build-time, I think we should make an effort to remove as much code and data as possible of that feature when built so.
Added build to travis to verify