Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit1604.c: fix implicit conv from 'SANITIZEcode' to 'CURLcode' #5476

Closed
wants to merge 1 commit into from

Conversation

@mback2k
Copy link
Member

mback2k commented May 28, 2020

GCC 10 warns about this with warning: implicit conversion
from 'SANITIZEcode' to 'CURLcode' [-Wenum-conversion]

Since 'expected_result' is not really of type 'CURLcode' and
it is not exposed in any way, we can just use 'SANITIZEcode'.

GCC 10 warns about this with warning: implicit conversion
  from 'SANITIZEcode' to 'CURLcode' [-Wenum-conversion]

Since 'expected_result' is not really of type 'CURLcode' and
it is not exposed in any way, we can just use 'SANITIZEcode'.
@mback2k mback2k requested a review from bagder May 28, 2020
@mback2k mback2k self-assigned this May 28, 2020
@bagder
bagder approved these changes May 28, 2020

CURLcode res = sanitize_file_name(&output, data[i].input, data[i].flags);
res = sanitize_file_name(&output, data[i].input, data[i].flags);

This comment has been minimized.

Copy link
@bagder

bagder May 29, 2020

Member

You could also just merge these two lines into a single statement...

This comment has been minimized.

Copy link
@mback2k

mback2k May 30, 2020

Author Member

I could, but then it would exceed the line length limit.

@mback2k mback2k closed this in 62314d6 May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.