unit1604.c: fix implicit conv from 'SANITIZEcode' to 'CURLcode' - #5476
Closed
mback2k wants to merge 1 commit into
Closed
unit1604.c: fix implicit conv from 'SANITIZEcode' to 'CURLcode'#5476mback2k wants to merge 1 commit into
mback2k wants to merge 1 commit into
Conversation
GCC 10 warns about this with warning: implicit conversion from 'SANITIZEcode' to 'CURLcode' [-Wenum-conversion] Since 'expected_result' is not really of type 'CURLcode' and it is not exposed in any way, we can just use 'SANITIZEcode'.
bagder
approved these changes
May 28, 2020
MarcelRaad
approved these changes
May 28, 2020
bagder
reviewed
May 29, 2020
| SANITIZEcode res; | ||
|
|
||
| CURLcode res = sanitize_file_name(&output, data[i].input, data[i].flags); | ||
| res = sanitize_file_name(&output, data[i].input, data[i].flags); |
Member
There was a problem hiding this comment.
You could also just merge these two lines into a single statement...
Member
Author
There was a problem hiding this comment.
I could, but then it would exceed the line length limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 10 warns about this with warning: implicit conversion
from 'SANITIZEcode' to 'CURLcode' [-Wenum-conversion]
Since 'expected_result' is not really of type 'CURLcode' and
it is not exposed in any way, we can just use 'SANITIZEcode'.