timeouts: move ms timeouts to timediff_t from time_t - #5479
Closed
bagder wants to merge 4 commits into
Closed
Conversation
For millisecond timers we like timediff_t better. Also, time_t can be unsigned so returning a negative value doesn't work then.
bagder
force-pushed
the
bagder/pingpong-timediff
branch
from
May 29, 2020 14:48
84bbbcc to
e085b00
Compare
unnecessary typecasts, some < 0 checks etc
bagder
changed the title
mback2k
added a commit
to mback2k/curl
that referenced
this pull request
Jun 5, 2020
Now that all functions in select.[ch] take timediff_t instead of the limited int or long, we can remove type conversions and related preprocessor checks to silence compiler warnings. Avoiding conversions from time_t was already done in 842f73d. Based upon curl#5262 Supersedes curl#5214, curl#5220 and curl#5221 Follow up to curl#5343 and curl#5479 Closes curl#5490
mback2k
added a commit
that referenced
this pull request
Jun 6, 2020
Now that all functions in select.[ch] take timediff_t instead of the limited int or long, we can remove type conversions and related preprocessor checks to silence compiler warnings. Avoiding conversions from time_t was already done in 842f73d. Based upon #5262 Supersedes #5214, #5220 and #5221 Follow up to #5343 and #5479 Closes #5490
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For millisecond timers we like timediff_t better. Also, time_t can be
unsigned so returning a negative value doesn't work then.