Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select: always use Sleep in Curl_wait_ms on Win32 #5489

Closed
wants to merge 1 commit into from

Conversation

@mback2k
Copy link
Member

mback2k commented May 30, 2020

Since Win32 almost always will also have USE_WINSOCK,
we can reduce complexity and always use Sleep there.

Suggested-by: Jay Satiro

Follow up to #5343

@mback2k mback2k requested review from bagder and jay May 30, 2020
@mback2k mback2k self-assigned this May 30, 2020
@mback2k mback2k force-pushed the mback2k:select-sleep-win32 branch from 5c0f7c8 to 93a2c02 May 30, 2020
@bagder
bagder approved these changes May 30, 2020
@jay
jay approved these changes May 31, 2020
Copy link
Member

jay left a comment

that ULONG_MAX < INFINITE check seems unnecessary you could just do it as ULONG_MAX -1/

Since Win32 almost always will also have USE_WINSOCK,
we can reduce complexity and always use Sleep there.

Suggested-by: Jay Satiro
Reviewed-by: Daniel Stenberg
Reviewed-by: Jay Satiro

Follow up to #5343
Closes #5489
@mback2k mback2k force-pushed the mback2k:select-sleep-win32 branch from 93a2c02 to 739adbc May 31, 2020
@mback2k
Copy link
Member Author

mback2k commented May 31, 2020

that ULONG_MAX < INFINITE check seems unnecessary you could just do it as ULONG_MAX -1/

Please take another look. I just updated this PR to work regardless of ULONG_MAX and INFINITE being equal or not. I think this one should be more robust now.

@mback2k mback2k requested review from jay and bagder May 31, 2020
lib/select.c Show resolved Hide resolved
@mback2k mback2k closed this in 5325b92 Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.