select: always use Sleep in Curl_wait_ms on Win32 - #5489
Closed
mback2k wants to merge 1 commit into
Closed
Conversation
mback2k
force-pushed
the
select-sleep-win32
branch
from
May 30, 2020 09:15
5c0f7c8 to
93a2c02
Compare
bagder
approved these changes
May 30, 2020
jay
approved these changes
May 31, 2020
jay
left a comment
jay
left a comment
Member
There was a problem hiding this comment.
that ULONG_MAX < INFINITE check seems unnecessary you could just do it as ULONG_MAX -1/
mback2k
force-pushed
the
select-sleep-win32
branch
from
May 31, 2020 18:34
93a2c02 to
739adbc
Compare
Member
Author
Please take another look. I just updated this PR to work regardless of ULONG_MAX and INFINITE being equal or not. I think this one should be more robust now. |
jay
reviewed
Jun 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Win32 almost always will also have USE_WINSOCK,
we can reduce complexity and always use Sleep there.
Suggested-by: Jay Satiro
Follow up to #5343