timeouts: move ms timeouts to timediff_t from int and long - #5490
Closed
mback2k wants to merge 1 commit into
Closed
Conversation
3 tasks
Member
|
This looks like a pretty wide overlap with #5479 ... |
Member
|
I propose I merge that first and then you can rebase this to remove the duplicates and we can focus on what isn't overlaps! |
Member
Author
Member
Author
I am fine with that. Thanks! |
bagder
approved these changes
May 31, 2020
Member
Author
|
@bagder please take another look. I updated this PR to include |
mback2k
marked this pull request as ready for review
May 31, 2020 18:14
mback2k
changed the title
Now that all functions in select.[ch] take timediff_t instead of the limited int or long, we can remove type conversions and related preprocessor checks to silence compiler warnings. Avoiding conversions from time_t was already done in 842f73d. Based upon curl#5262 Supersedes curl#5214, curl#5220 and curl#5221 Follow up to curl#5343 and curl#5479 Closes curl#5490
mback2k
changed the title
Member
Author
|
Merged now, because except 1 unrelated Windows build all CIs were green, including the c-ares builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that all functions in select.[ch] take timediff_t instead
of the limited time_t or int, we can remove type conversions
and related preprocessor checks to silence compiler warnings.