Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: add unicode to feature list #5491

Closed
wants to merge 1 commit into from
Closed

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented May 30, 2020

Make builds having Unicode support on Windows detectable programmatically and by showing it in the Features header.

Note: Naming suggestions are welcome. I'd prefer this not to be a "Windows-thing", but I'm not aware of any other platform having a separate Unicode API.

@bagder
Copy link
Member

@bagder bagder commented Jun 1, 2020

What exactly does it mean (for users) ? I mean this adds the docs that libcurl was built with unicode support but how is that relevant. Maybe we should also document that somewhere?

I realize that Windows is the only build that differentiates unicode vs non-unicode - right now - but maybe we can still omit the "win" part from the name and then if other platforms later on find a use for the bit for the same purpose, it will fit better?

@vszakats
Copy link
Member Author

@vszakats vszakats commented Jun 1, 2020

@bagder: For users I think it means that non-ASCII characters in filenames, on the command-line will actually work (or if they don't, it's something to report.)

I do agree to drop the WIN part. Will update in a few.

@vszakats vszakats force-pushed the vszakats:feat-winuni branch from 0afe4f5 to d736d09 Jul 14, 2020
@vszakats vszakats force-pushed the vszakats:feat-winuni branch from d736d09 to 53a2c27 Jul 14, 2020
@vszakats
Copy link
Member Author

@vszakats vszakats commented Jul 14, 2020

[Rebased to master and squashed.]

@vszakats vszakats closed this in 8fa3f78 Jul 14, 2020
@vszakats vszakats deleted the vszakats:feat-winuni branch Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.