windows: add unicode to feature list #5491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
added
feature-window
Member
|
What exactly does it mean (for users) ? I mean this adds the docs that libcurl was built with unicode support but how is that relevant. Maybe we should also document that somewhere? I realize that Windows is the only build that differentiates unicode vs non-unicode - right now - but maybe we can still omit the "win" part from the name and then if other platforms later on find a use for the bit for the same purpose, it will fit better? |
Member
Author
|
@bagder: For users I think it means that non-ASCII characters in filenames, on the command-line will actually work (or if they don't, it's something to report.) I do agree to drop the |
MarcelRaad
approved these changes
Jun 1, 2020
mback2k
approved these changes
Jun 17, 2020
Member
Author
|
[Rebased to master and squashed.] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make builds having Unicode support on Windows detectable programmatically and by showing it in the
Featuresheader.Note: Naming suggestions are welcome. I'd prefer this not to be a "Windows-thing", but I'm not aware of any other platform having a separate Unicode API.