Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: set FLAG_TRUSTED_FIRST unconditionally #5530

Closed
wants to merge 1 commit into from

Conversation

@freedge
Copy link
Contributor

@freedge freedge commented Jun 6, 2020

On some systems, openssl 1.0 is still the default, but it has been patched to
contain all the recent security fixes. As a result of this patching, it is
possible for macro X509_V_FLAG_NO_ALT_CHAINS to be defined, while the previous
behavior of openssl to not look at trusted chains first, remains.

Problem is that curl will fail to verify websites stills serving an expired, intermediate certificate, which happened quite a few times recently: https://www.agwa.name/blog/post/fixing_the_addtrust_root_expiration

Fix it: ensure X509_V_FLAG_TRUSTED_FIRST is always set, do not try to probe for
the behavior of openssl based on the existence of this macro.

On some systems, openssl 1.0 is still the default, but it has been patched to
contain all the recent security fixes. As a result of this patching, it is
possible for macro X509_V_FLAG_NO_ALT_CHAINS to be defined, while the previous
behavior of openssl to not look at trusted chains first, remains.

Fix it: ensure X509_V_FLAG_TRUSTED_FIRST is always set, do not try to probe for
the behavior of openssl based on the existence ofmacros.
@bagder bagder added the SSL/TLS label Jun 6, 2020
@bagder
bagder approved these changes Jun 6, 2020
@bagder
Copy link
Member

@bagder bagder commented Jun 6, 2020

Thanks!

@bagder bagder closed this in e2de2d5 Jun 6, 2020
@jay
Copy link
Member

@jay jay commented Jun 6, 2020

Too fast did you investigate his claim? I was the one who set it not to use trusted first when alt chains was in effect. @mattcaswell wrote "It makes no sense to combine the trusted first and alt chains strategies. With trusted first we have already checked all of the possible chains by the time we get to the end of the peer provided list - so there is no point in then popping certs off the top of our chain and checking the trusted store again."

Ref: https://curl.haxx.se/mail/lib-2020-06/0001.html
Ref: https://curl.haxx.se/mail/archive-2020-06/0011.html

@bagder
Copy link
Member

@bagder bagder commented Jun 6, 2020

  1. From what I've been told this is what OpenSSL >= 1.1.0 does by itself already
  2. This is what python does and thanks to this they avoided the AddTrust issue
  3. This actually fixes works-around the AddTrust issue

So, no, it wasn't too fast. But I'm open for alternative takes. Not sure spending a lot of brain-cells on old OpenSSL versions is worth it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.