Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

altsvc: decrease entry count when expired entry is removed #5553

Closed
wants to merge 1 commit into from

Conversation

@jay
Copy link
Member

@jay jay commented Jun 11, 2020

Prior to this change the lookup function did not adjust the count
when purging expired entries. AFAICS the count is only used by test
unit1654 so there does not appear to have been any consequence.

Closes #xxxx


I noticed this while investigating #5552 but it is not related.

Prior to this change the lookup function did not adjust the count
when purging expired entries. AFAICS the count is only used by test
unit1654 so there does not appear to have been any consequence.

Closes #xxxx
@bagder
bagder approved these changes Jun 11, 2020
@jay
Copy link
Member Author

@jay jay commented Jun 11, 2020

I wonder couldn't as->list.size be used why keep track separately with num

@bagder
Copy link
Member

@bagder bagder commented Jun 11, 2020

That would both save a variable and make sure they're always in sync, agreed!

bagder added a commit that referenced this pull request Jun 12, 2020
It was superfluous since we have the list.size alredy

Reported-by: Jay Satiro
Fixes #5553
@bagder bagder closed this in b88bded Jun 12, 2020
@jay jay deleted the jay:altsvc_fix_exp_entry_num branch Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.