altsvc: decrease entry count when expired entry is removed #5553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the lookup function did not adjust the count when purging expired entries. AFAICS the count is only used by test unit1654 so there does not appear to have been any consequence. Closes #xxxx
bagder
approved these changes
Jun 11, 2020
|
I wonder couldn't as->list.size be used why keep track separately with num |
|
That would both save a variable and make sure they're always in sync, agreed! |
bagder
added a commit
that referenced
this pull request
Jun 12, 2020
It was superfluous since we have the list.size alredy Reported-by: Jay Satiro Fixes #5553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the lookup function did not adjust the count
when purging expired entries. AFAICS the count is only used by test
unit1654 so there does not appear to have been any consequence.
Closes #xxxx
I noticed this while investigating #5552 but it is not related.