Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODE_REVIEW.md: how to do code reviews in curl #5555

Closed
wants to merge 1 commit into from
Closed

CODE_REVIEW.md: how to do code reviews in curl #5555

wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented Jun 11, 2020 •
edited

When this document gets merged, it should satisfy the final criteria for curl to become Gold Level complaint CII Best Practices.

See https://bestpractices.coreinfrastructure.org/en/projects/63
@bagder bagder requested review from danielgustafsson and jay Jun 11, 2020
@danielgustafsson
danielgustafsson reviewed Jun 11, 2020
View changes
Copy link
Member

@danielgustafsson danielgustafsson left a comment

👍 on tackling this!
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
@bagder bagder force-pushed the bagder/code-review branch from 35b528e to 8df09db Jun 11, 2020
@bagder
Copy link
Member Author

@bagder bagder commented Jun 11, 2020

Take two - with @danielgustafsson's comments taken care of and merged in.
@richsalz
richsalz reviewed Jun 11, 2020
View changes
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
@hugovk
hugovk reviewed Jun 11, 2020
View changes
Copy link

@hugovk hugovk left a comment

Some little nits :)
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/Makefile.am Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
@danielgustafsson
danielgustafsson reviewed Jun 11, 2020
View changes
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
bagder added a commit that referenced this pull request Jun 12, 2020
@bagder
CODE_REVIEW.md: how to do code reviews in curl
Verified
This commit was signed with a verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
Loading status checks…
321c9ea 
Assisted-by: Daniel Gustafsson
Assisted-by: Rich Salz
Assisted-by: Hugo van Kemenade

Closes #5555
@bagder bagder force-pushed the bagder/code-review branch from 937ed32 to 321c9ea Jun 12, 2020
@bagder
Copy link
Member Author

@bagder bagder commented Jun 12, 2020

Take three, squashed into a single commit again for easier further review commenting. If any.
@xquery
xquery reviewed Jun 12, 2020
View changes
docs/CODE_REVIEW.md Show resolved Hide resolved
@xquery
xquery reviewed Jun 12, 2020
View changes
docs/CODE_REVIEW.md Show resolved Hide resolved
@xquery
xquery reviewed Jun 12, 2020
View changes
docs/CODE_REVIEW.md Show resolved Hide resolved
@mback2k
mback2k reviewed Jun 12, 2020
View changes
docs/CODE_REVIEW.md Show resolved Hide resolved
@mback2k
mback2k reviewed Jun 12, 2020
View changes
docs/CODE_REVIEW.md Show resolved Hide resolved
@bagder
CODE_REVIEW.md: how to do code reviews in curl
Verified
This commit was signed with a verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
Loading status checks…
97af051 
Assisted-by: Daniel Gustafsson
Assisted-by: Rich Salz
Assisted-by: Hugo van Kemenade
Assisted-by: James Fuller
Assisted-by: Marc Hörsken
Assisted-by: Jay Satiro

Closes #5555
@bagder bagder force-pushed the bagder/code-review branch from 9d8023f to 97af051 Jun 12, 2020
@bagder
Copy link
Member Author

@bagder bagder commented Jun 12, 2020

Take four was squashed and force-pushed.
@bagder bagder closed this in 350a99b Jun 13, 2020
@bagder
Copy link
Member Author

@bagder bagder commented Jun 13, 2020

Thank you everyone for awesome feedback and help with this. If you find more things to fix, let's do them as regular pull-requests from now!
@bagder bagder deleted the bagder/code-review branch Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mback2k mback2k

@danielgustafsson danielgustafsson

@xquery xquery

@hugovk hugovk

@richsalz richsalz

@jay jay

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@bagder @mback2k @danielgustafsson @xquery @jay @hugovk @richsalz