Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODE_REVIEW.md: how to do code reviews in curl #5555

Closed
wants to merge 1 commit into from
Closed

Conversation

@bagder
Copy link
Member

bagder commented Jun 11, 2020

When this document gets merged, it should satisfy the final criteria for curl to become Gold Level complaint CII Best Practices.

See https://bestpractices.coreinfrastructure.org/en/projects/63

@bagder bagder requested review from danielgustafsson and jay Jun 11, 2020
Copy link
Member

danielgustafsson left a comment

👍 on tackling this!

docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
@bagder bagder force-pushed the bagder/code-review branch from 35b528e to 8df09db Jun 11, 2020
@bagder
Copy link
Member Author

bagder commented Jun 11, 2020

Take two - with @danielgustafsson's comments taken care of and merged in.

docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
Copy link

hugovk left a comment

Some little nits :)

docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/Makefile.am Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Outdated Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
docs/CODE_REVIEW.md Show resolved Hide resolved
bagder added a commit that referenced this pull request Jun 12, 2020
Assisted-by: Daniel Gustafsson
Assisted-by: Rich Salz
Assisted-by: Hugo van Kemenade

Closes #5555
@bagder bagder force-pushed the bagder/code-review branch from 937ed32 to 321c9ea Jun 12, 2020
@bagder
Copy link
Member Author

bagder commented Jun 12, 2020

Take three, squashed into a single commit again for easier further review commenting. If any.

Assisted-by: Daniel Gustafsson
Assisted-by: Rich Salz
Assisted-by: Hugo van Kemenade
Assisted-by: James Fuller
Assisted-by: Marc Hörsken
Assisted-by: Jay Satiro

Closes #5555
@bagder bagder force-pushed the bagder/code-review branch from 9d8023f to 97af051 Jun 12, 2020
@bagder
Copy link
Member Author

bagder commented Jun 12, 2020

Take four was squashed and force-pushed.

@bagder bagder closed this in 350a99b Jun 13, 2020
@bagder
Copy link
Member Author

bagder commented Jun 13, 2020

Thank you everyone for awesome feedback and help with this. If you find more things to fix, let's do them as regular pull-requests from now!

@bagder bagder deleted the bagder/code-review branch Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.