CODE_REVIEW.md: how to do code reviews in curl #5555
Closed
Conversation
|
|
|
Take two - with @danielgustafsson's comments taken care of and merged in. |
|
Some little nits :) |
bagder
added a commit
that referenced
this pull request
Jun 12, 2020
Assisted-by: Daniel Gustafsson Assisted-by: Rich Salz Assisted-by: Hugo van Kemenade Closes #5555
|
Take three, squashed into a single commit again for easier further review commenting. If any. |
Assisted-by: Daniel Gustafsson Assisted-by: Rich Salz Assisted-by: Hugo van Kemenade Assisted-by: James Fuller Assisted-by: Marc Hörsken Assisted-by: Jay Satiro Closes #5555
|
Take four was squashed and force-pushed. |
|
Thank you everyone for awesome feedback and help with this. If you find more things to fix, let's do them as regular pull-requests from now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When this document gets merged, it should satisfy the final criteria for curl to become Gold Level complaint CII Best Practices.
See https://bestpractices.coreinfrastructure.org/en/projects/63