Update socks.c

[ihsinme]

I propose to eliminate the risk of using the signed type (ssize_t) in the arithmetic of pointers, replacing it with an unsigned one (size_t). While in this context, the signed type (ssize_t) is used unnecessarily.

[danielgustafsson]

The outstanding member in struct connstate is of type ssize_t, so it makes sense to calculate using that type. Also, I'm not sure I see the the threat vector here, can you elaborate on why you think ssize_t is dangerous here?

[danielgustafsson]

This is bogus indentation.

[ihsinme]

I see a threat in the following.
when the variables packetsize, hostnamelen or their sum increase beyond positive values, memory overflow to which socksreq packetsize points can occur. however, ongoing checks will not provide protection.

[bagder]

I don't think that's a "threat", but since the fix removes a typecast I still think its a good one.

[bagder]

Thanks!

[ihsinme]

Thanks you