Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appveyor: collect libcurl.dll with version suffix #5659

Closed
wants to merge 1 commit into from
Closed

appveyor: collect libcurl.dll with version suffix #5659

wants to merge 1 commit into from

Conversation

@mback2k
Copy link
Member

mback2k commented Jul 8, 2020 •
edited

Currently the wildcard is not matching DLLs generated by the msys/mingw based builds.
@mback2k mback2k self-assigned this Jul 8, 2020
@mback2k
Copy link
Member Author

mback2k commented Jul 8, 2020

Still not working correctly, even though the DLL should be at lib\.libs\ļibcurl-4.dll just like in my local builds. Will add an ls to check.
@jay
jay reviewed Jul 9, 2020
View changes
appveyor.yml Outdated Show resolved Hide resolved
@mback2k
Copy link
Member Author

mback2k commented Jul 9, 2020

I am currently working on this draft PR via the GitHub website, I will squash the individual GitHub commits before merge.
mback2k added a commit that referenced this pull request Jul 12, 2020
@mback2k
appveyor: collect libcurl.dll variants with prefix or suffix
Verified
This commit was signed with a verified signature.
mback2k Marc Hörsken
GPG key ID: 61E03CBED7BC859E Learn about signing commits
Loading status checks…
324952c 
On some platforms libcurl is build with a platform-specific
prefix and/or a version number suffix.

Assisted-by: Jay Satiro
Reviewed-by: Marcel Raad

Closes #5659
@mback2k mback2k force-pushed the mback2k-appveyor-dll branch from cf35605 to 324952c Jul 12, 2020
@mback2k mback2k marked this pull request as ready for review Jul 12, 2020
@mback2k mback2k force-pushed the mback2k-appveyor-dll branch from 324952c to 5789e3a Jul 12, 2020
@mback2k
appveyor: collect libcurl.dll variants with prefix or suffix
Verified
This commit was signed with a verified signature.
mback2k Marc Hörsken
GPG key ID: 61E03CBED7BC859E Learn about signing commits
Loading status checks…
5789e3a 
On some platforms libcurl is build with a platform-specific
prefix and/or a version number suffix.

Assisted-by: Jay Satiro

Closes #5659
@mback2k mback2k closed this in 35fa07c Jul 13, 2020
@mback2k mback2k deleted the mback2k-appveyor-dll branch Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay jay

Assignees

@mback2k mback2k

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@mback2k @jay
You can’t perform that action at this time.