CURLKHSTAT_FINE_REPLACE

[mickae1]

add the functionality to remove the old host+key that doesn't match anymore. It's usefull to prevent the knownhost file to grow too much.

I've a problem during the compilation:

NMAKE : fatal error U1073: incapable d'obtenir '..\src\tool_hugehelp.c'

[ghost]

Congratulations 🎉. DeepCode analyzed your code in 0.222 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

[bagder]

The libssh backend is also quite popular so I think it would make sense to make sure that is updated accordingly!

[bagder]

Don't forget make checksrc:

./vssh/libssh2.c:444:48: warning: Trailing whitespace (TRAILINGSPACE)
     struct ssh_conn *sshc = &conn->proto.sshc;  
                                                ^
./vssh/libssh2.c:590:53: warning: Trailing whitespace (TRAILINGSPACE)
         else if(rc == CURLKHSTAT_FINE_ADD_TO_FILE || 
                                                     ^
checksrc: 0 errors and 2 warnings
checksrc: 0 errors and 6 warnings suppressed

Also, please consider squashing the commits and force-pushing after extensive edits so that we can now do a fresh review on the entire thing a little easier.

[mickae1]

Ok, I will do it... In vacation for the moment

[mickae1]

done :) waiting for the review ;)

[bagder]

The 1119 still fails.

The commit message mentions the wrong name and doesn't follow the style guide

[bagder]

The 1119 test still fails. You need to add CURLKHSTAT_FINE_REPLACE to docs/libcurl/symbols-in-versions

[mickae1]

The 1119 test still fails. You need to add CURLKHSTAT_FINE_REPLACE to docs/libcurl/symbols-in-versions

problem corrected :)

[mickae1]

@bagder requested changes

I've done the change, how can I say that it is done ?

[bagder]

You still forget to run make checksrc and several CI jobs pointed out this problem to you:

./vssh/libssh2.c:444:48: warning: Trailing whitespace (TRAILINGSPACE)
     struct ssh_conn *sshc = &conn->proto.sshc;  
                                                ^
./vssh/libssh2.c:590:53: warning: Trailing whitespace (TRAILINGSPACE)
         else if(rc == CURLKHSTAT_FINE_ADD_TO_FILE || 
                                                     ^

[mickae1]

You still forget to run make checksrc and several CI jobs pointed out this problem to you:

./vssh/libssh2.c:444:48: warning: Trailing whitespace (TRAILINGSPACE)
     struct ssh_conn *sshc = &conn->proto.sshc;  
                                                ^
./vssh/libssh2.c:590:53: warning: Trailing whitespace (TRAILINGSPACE)
         else if(rc == CURLKHSTAT_FINE_ADD_TO_FILE || 
                                                     ^

@bagder
sorry ... it's because, I'm on windows, and this doesn't work:

curl\winbuild> nmake checksrc ..\lib\vssh\libssh2.c

I've corrected the trailingspace 👍

[bagder]

I believe projects/checksrc.bat should be possible to invoke by windows users.

[mickae1]

projects/checksrc.bat

Thx,
@bagder

curl> projects/checksrc.bat .\lib\vssh\libssh2.c

no result from the command :)

looks like that it's okay 👍

[bagder]

Thanks!