configure: allow disabling warnings #5689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `--enable-warnings`, it was not possible to disable warnings via CFLAGS that got explicitly enabled with that warnings. Now warnings are not enabled anymore if they are explicitly disabled (or enabled) in CFLAGS. This works for at least GCC, clang, and TCC as they have corresponding `-Wno-` options for every warning. Closes
|
For some context: what I want to do is enable warnings-as-errors for our macOS CI builds. Most have it disabled at the moment because of a |
bagder
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
With
--enable-warnings, it was not possible to disable warnings viaCFLAGS that got explicitly enabled with that warnings. Now warnings are
not enabled anymore if they are explicitly disabled (or enabled) in
CFLAGS. This works for at least GCC, clang, and TCC as they have
corresponding
-Wno-options for every warning.I'm not fluent with m4, so there might be a better or cleaner way to do that.
Tested with GCC (on Windows and macOS) and clang (on macOS), but TCC should behave the same.