Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: allow disabling warnings #5689

Closed
wants to merge 1 commit into from

Conversation

@MarcelRaad
Copy link
Member

MarcelRaad commented Jul 15, 2020

With --enable-warnings, it was not possible to disable warnings via
CFLAGS that got explicitly enabled with that warnings. Now warnings are
not enabled anymore if they are explicitly disabled (or enabled) in
CFLAGS. This works for at least GCC, clang, and TCC as they have
corresponding -Wno- options for every warning.

I'm not fluent with m4, so there might be a better or cleaner way to do that.
Tested with GCC (on Windows and macOS) and clang (on macOS), but TCC should behave the same.

With `--enable-warnings`, it was not possible to disable warnings via
CFLAGS that got explicitly enabled with that warnings. Now warnings are
not enabled anymore if they are explicitly disabled (or enabled) in
CFLAGS. This works for at least GCC, clang, and TCC as they have
corresponding `-Wno-` options for every warning.

Closes
@MarcelRaad
Copy link
Member Author

MarcelRaad commented Jul 16, 2020

For some context: what I want to do is enable warnings-as-errors for our macOS CI builds. Most have it disabled at the moment because of a -Wvla warning in a brotli header.

@MarcelRaad MarcelRaad added the build label Jul 16, 2020
@bagder
bagder approved these changes Jul 16, 2020
@MarcelRaad MarcelRaad deleted the MarcelRaad:allow_disabling_warnings branch Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.