Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings on macOS #5695

Closed
wants to merge 2 commits into from
Closed

Conversation

@MarcelRaad
Copy link
Member

MarcelRaad commented Jul 17, 2020

  • The MD4 and MD5 functions have been deprecated in macOS 10.15
  • timeval::tv_usec is a 32-bit int and timespec::tv_nsec is a 64-bit long on macOS
MarcelRaad added 2 commits Jul 16, 2020
They are marked as deprecated for -mmacosx-version-min >= 10.15,
which might result in warnings-as-errors.

Closes
timeval::tv_usec might be a 32-bit integer and timespec::tv_nsec might
be a 64-bit integer. This is the case when building for recent macOS
versions, for example. Just treat tv_usec as an int, which should
hopefully always be sufficient on systems with
`HAVE_CLOCK_GETTIME_MONOTONIC`.

Closes
@MarcelRaad MarcelRaad added the build label Jul 17, 2020
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Jul 19, 2020
timeval::tv_usec might be a 32-bit integer and timespec::tv_nsec might
be a 64-bit integer. This is the case when building for recent macOS
versions, for example. Just treat tv_usec as an int, which should
hopefully always be sufficient on systems with
`HAVE_CLOCK_GETTIME_MONOTONIC`.

Closes curl#5695
@MarcelRaad MarcelRaad deleted the MarcelRaad:macos_warnings branch Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.