Skip to content

Fix compiler warnings on macOS#5695

Closed
MarcelRaad wants to merge 2 commits into
curl:masterfrom
MarcelRaad:macos_warnings
Closed

Fix compiler warnings on macOS#5695
MarcelRaad wants to merge 2 commits into
curl:masterfrom
MarcelRaad:macos_warnings

Conversation

@MarcelRaad

@MarcelRaad MarcelRaad commented Jul 17, 2020

Copy link
Copy Markdown
Member
  • The MD4 and MD5 functions have been deprecated in macOS 10.15
  • timeval::tv_usec is a 32-bit int and timespec::tv_nsec is a 64-bit long on macOS

@MarcelRaad
md(4|5): don't use deprecated macOS functions
9ee8c89 
They are marked as deprecated for -mmacosx-version-min >= 10.15,
which might result in warnings-as-errors.

Closes
@MarcelRaad
util: silence conversion warnings
7e5776d 
timeval::tv_usec might be a 32-bit integer and timespec::tv_nsec might
be a 64-bit integer. This is the case when building for recent macOS
versions, for example. Just treat tv_usec as an int, which should
hopefully always be sufficient on systems with
`HAVE_CLOCK_GETTIME_MONOTONIC`.

Closes
MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Jul 19, 2020
@MarcelRaad
util: silence conversion warnings
c90e48c 
timeval::tv_usec might be a 32-bit integer and timespec::tv_nsec might
be a 64-bit integer. This is the case when building for recent macOS
versions, for example. Just treat tv_usec as an int, which should
hopefully always be sufficient on systems with
`HAVE_CLOCK_GETTIME_MONOTONIC`.

Closes curl#5695
@MarcelRaad
MarcelRaad deleted the macos_warnings branch July 19, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sterchelen sterchelen sterchelen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarcelRaad @sterchelen