Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildconf: cleanup #5701

Closed
wants to merge 3 commits into from
Closed

buildconf: cleanup #5701

wants to merge 3 commits into from

Conversation

@carenas
Copy link
Contributor

@carenas carenas commented Jul 19, 2020

mainly to allow for a clean:

$ shellcheck -fgcc --enable=all -S warning buildconf

@jay jay added the tidy-up label Jul 20, 2020
buildconf Outdated Show resolved Hide resolved
carenas added 3 commits Jul 19, 2020
reported as error SC2145[1] by shellcheck, but not expected to cause
any behavioural differences otherwise.

[1] https://github.com/koalaman/shellcheck/wiki/SC2145
retired with 09f2781 but kept around as
the name is generic enough that it might be in use and relied upon from
the environment.
no longer needed after 4259d2d
@carenas carenas force-pushed the carenas:buildconf branch from 0587470 to 0ec8bc3 Jul 30, 2020
@bagder bagder closed this in 7270795 Jul 31, 2020
@bagder
Copy link
Member

@bagder bagder commented Jul 31, 2020

Thanks!

@carenas carenas deleted the carenas:buildconf branch Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.