Skip to content

doh: remove redundant cast #5704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doh: remove redundant cast #5704

wants to merge 1 commit into from

Conversation

@MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Jul 20, 2020

No description provided.

cvengler
cvengler approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@cvengler cvengler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. However while looking at this file I am curious if addr should really be a sockaddr_in because of IPv6

@MarcelRaad MarcelRaad deleted the remove_redundant_cast branch July 21, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bagder bagder bagder approved these changes

+2 more reviewers

@cvengler cvengler cvengler approved these changes

@sterchelen sterchelen sterchelen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MarcelRaad @bagder @cvengler @sterchelen