connect: output the same error msg on both code paths#5708
Closed
mback2k wants to merge 1 commit into
Closed
Conversation
Member
Author
|
I am also not sure if the two "Connection failed" Lines 954 to 958 in d746ff1 |
Member
|
I agree. Those two infof() error message should probably be removed in preference of the one with more details. |
Member
Author
|
@bagder are you sure? The more detailed verbose message is hidden in case CURL_DISABLE_VERBOSE_STRINGS is defined. |
62bba56 to
6af4350
Compare
Member
|
Yes, as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed verifyconnect on CURL_CSELECT_OUT printed the
error message "Connection failed", but the same failure
on CURL_CSELECT_ERR did not. This commit brings it in line.