Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/macos: enable warnings as errors for CMake builds #5716

Closed
wants to merge 1 commit into from

Conversation

@MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Jul 23, 2020

No description provided.

Closes
@MarcelRaad
Copy link
Member Author

@MarcelRaad MarcelRaad commented Jul 23, 2020

The need for -Wno-error=undef -Wno-error=conversion is because of checks which are implemented in configure, but not in CMake. Specifically, the check for CURL_SA_FAMILY_T and the check for HAVE_BUILTIN_AVAILABLE.

@MarcelRaad MarcelRaad deleted the MarcelRaad:ci_macos_cmake_werror branch Jul 25, 2020
@mback2k mback2k added the CI label Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.