Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow connect-only connections to be closed when unused #5749

Closed

Conversation

@marc-groundctl
Copy link
Contributor

@marc-groundctl marc-groundctl commented Jul 30, 2020

As mentioned in #4426 (comment), commit 1d5c427 fixes issue 4426 but introduces another issue where connect-only connections completed in a multi handle would be kept alive for the entire lifetime of that multi handle. This patch disassociates these connections from their easy handle when that easy handle is removed from the multi, allowing them to be cleaned up normally.

Previously any connect-only connections in a multi handle would be kept
alive until the multi handle was closed.  Since these connections cannot
be re-used, they can be marked for closure when the associated easy
handle is removed from the multi handle.
@marc-groundctl marc-groundctl force-pushed the marc-groundctl:close-more-connections branch from 2e25441 to cd9595a Jul 30, 2020
lib/multi.c Show resolved Hide resolved
@bagder
bagder approved these changes Aug 1, 2020
@bagder bagder closed this in d5bb459 Aug 1, 2020
@bagder
Copy link
Member

@bagder bagder commented Aug 1, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.