Allow connect-only connections to be closed when unused #5749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously any connect-only connections in a multi handle would be kept alive until the multi handle was closed. Since these connections cannot be re-used, they can be marked for closure when the associated easy handle is removed from the multi handle.
marc-groundctl
force-pushed
the
close-more-connections
branch
from
2e25441
to
cd9595a
Compare
bagder
reviewed
Jul 30, 2020
bagder
approved these changes
Aug 1, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As mentioned in #4426 (comment), commit 1d5c427 fixes issue 4426 but introduces another issue where connect-only connections completed in a multi handle would be kept alive for the entire lifetime of that multi handle. This patch disassociates these connections from their easy handle when that easy handle is removed from the multi, allowing them to be cleaned up normally.