Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildconf: invoke 'autoreconf -fi' instead #5853

Closed
wants to merge 1 commit into from
Closed

buildconf: invoke 'autoreconf -fi' instead #5853

wants to merge 1 commit into from

Conversation

@bagder
Copy link
Member

bagder commented Aug 25, 2020

The custom script isn't necessary but remains for simplicity, and just
invokes autoreconf.
@bagder bagder added the build label Aug 25, 2020
@mback2k
Copy link
Member

mback2k commented Aug 25, 2020

My buildbots using testcurl report this error: testcurl: buildconf was NOT successful
@bagder
Copy link
Member Author

bagder commented Aug 25, 2020

Ah, yes thanks I need to address that!
@bagder
buildconf: invoke 'autoreconf -fi' instead
Verified
This commit was signed with a verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2 Learn about signing commits
Loading status checks…
c245931 
The custom script isn't necessary anymore - but remains for simplicity,
and just invokes autoreconf.

Closes #5853
@bagder bagder force-pushed the bagder/buildconf-removed branch from ef5d929 to c245931 Aug 26, 2020
@bagder bagder closed this in 8586853 Aug 27, 2020
@bagder bagder deleted the bagder/buildconf-removed branch Aug 27, 2020
mback2k added a commit to mback2k/curl that referenced this pull request Aug 29, 2020
@mback2k
buildconf: exec autoreconf to avoid additional process
Verified
This commit was signed with a verified signature.
mback2k Marc Hörsken
GPG key ID: 61E03CBED7BC859E Learn about signing commits
578641c 
Also make buildconf exit with the return code of autoreconf.

Follow up to curl#5853
@mback2k mback2k mentioned this pull request Aug 29, 2020
Closed
mback2k added a commit that referenced this pull request Aug 29, 2020
@mback2k
buildconf: exec autoreconf to avoid additional process
Verified
This commit was signed with a verified signature.
mback2k Marc Hörsken
GPG key ID: 61E03CBED7BC859E Learn about signing commits
Loading status checks…
8b69ac0 
Also make buildconf exit with the return code of autoreconf.

Reviewed-by: Daniel Stenberg

Follow up to #5853
Closes #5890
emilengler added a commit to emilengler/curl that referenced this pull request Sep 6, 2020
@emilengler
build: Add forgotten asteriskes
Verified
This commit was signed with a verified signature.
emilengler Emil Engler
GPG key ID: 2F6D4145C55FC7C7 Learn about signing commits
7cb27be 
This is a minor issue but those asteriskes at the end were
most likely forgotten by curl#5853
@emilengler emilengler mentioned this pull request Sep 6, 2020
Closed
emilengler added a commit to emilengler/curl that referenced this pull request Sep 6, 2020
@emilengler
build: Add forgotten asterisks
Verified
This commit was signed with a verified signature.
emilengler Emil Engler
GPG key ID: 2F6D4145C55FC7C7 Learn about signing commits
6790713 
This is a minor issue but those asterisks at the end were
most likely forgotten by curl#5853

Closes curl#5925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bagder @mback2k
You can’t perform that action at this time.