Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
win32: drop support for WinSock version 1, require version 2 #5854
New PR content:
IPv6, telnet and now also the multi API require WinSock
Therefore we think it is time to drop support for version 1.
Original PR content:
While digging through the WinSock setup in the curl source code, I found out that there is actually code to handle the differences between WinSock version 1 and 2. Therefore the changes introduced with #5634 should also still support compilation against older WinSock versions.
An alternative to repeating the same check in every
Update the ifdef-jungle to check for WinSock version 2.
Follow up to #5634
Yes. Who is using it? Unless you have Windows 95 that for some reason doesn't have winsock 2. And anyway who is building for that and how? I don't even know if that's still possible, this aside.
Okay, fine with me. But does that then mean that we shouldn't check for WinSock version 2 and just assume
All of this could probably be simplified to compile time only checks if we just assume WinSock 2 and drop the dynamic library load, as suggested here: #5634 (comment)
Okay, so I will start on reworking this PR into something to drop support for WinSock 1 and just assume WinSock 2 statically.
IPv6, telnet and now also the multi API require WinSock version 2 which is available starting with Windows 95. Therefore we think it is time to drop support for version 1.
Drop dynamic loading of ws2_32.dll and instead rely on the imported version which is now required to be at least 2.2. Reviewed-by: Marcel Raad Reviewed-by: Jay Satiro Reviewed-by: Daniel Stenberg Reviewed-by: Viktor Szakats Closes #5854