New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: handle connection state winsock events #5867
Conversation
Learn from the way Cygwin handles and maps the WinSock events to simulate correct and complete poll and select behaviour according to Richard W. Stevens Network Programming book.
Looks reasonable to me, I'll take cygwin's word for it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me but I'd try for a clean CI. I tried to restart the failed azure jobs but apparently I don't have access to do that. Who is managing the azure instances? I assume the typical arbitrary unrelated failures, but please find out before landing this.
Thanks. Of course, I am always looking at the Windows CI (that I created). I think only Daniel and I currently can manage the Azure DevOps project, but you can use the following: /azp run windows |
Azure Pipelines successfully started running 1 pipeline(s). |
Learn from the way Cygwin handles and maps the WinSock events to simulate correct and complete poll and select behaviour according to Richard W. Stevens Network Programming book. Follow up to curl#5867
Learn from the way Cygwin handles and maps the WinSock events
to simulate correct and complete poll and select behaviour
according to Richard W. Stevens Network Programming book.
Follow up to #5634
References to the corresponding mapping code in Cygwin:
https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=winsup/cygwin/select.cc;h=9f1a8a57a07c9098bd497bc680b133310e1d2a35;hb=HEAD#l1631
https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=winsup/cygwin/fhandler_socket_inet.cc;h=2b50671e533d70783cd1af00d8cc39e292e93ee8;hb=HEAD
cc @rcombs