Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: handle connection state winsock events #5867

Closed
wants to merge 1 commit into from

Conversation

@mback2k
Copy link
Member

@mback2k mback2k commented Aug 26, 2020

Learn from the way Cygwin handles and maps the WinSock events
to simulate correct and complete poll and select behaviour
according to Richard W. Stevens Network Programming book.

Follow up to #5634

References to the corresponding mapping code in Cygwin:
https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=winsup/cygwin/select.cc;h=9f1a8a57a07c9098bd497bc680b133310e1d2a35;hb=HEAD#l1631
https://cygwin.com/git/?p=newlib-cygwin.git;a=blob;f=winsup/cygwin/fhandler_socket_inet.cc;h=2b50671e533d70783cd1af00d8cc39e292e93ee8;hb=HEAD

cc @rcombs

Learn from the way Cygwin handles and maps the WinSock events
to simulate correct and complete poll and select behaviour
according to Richard W. Stevens Network Programming book.
@mback2k mback2k added the Windows label Aug 26, 2020
@mback2k mback2k requested review from jay and MarcelRaad Aug 26, 2020
@mback2k mback2k self-assigned this Aug 26, 2020
@rcombs
Copy link
Contributor

@rcombs rcombs commented Aug 26, 2020

Looks reasonable to me, I'll take cygwin's word for it!

@jay
jay approved these changes Aug 27, 2020
Copy link
Member

@jay jay left a comment

Looks fine to me but I'd try for a clean CI. I tried to restart the failed azure jobs but apparently I don't have access to do that. Who is managing the azure instances? I assume the typical arbitrary unrelated failures, but please find out before landing this.

@mback2k
Copy link
Member Author

@mback2k mback2k commented Aug 27, 2020

Thanks. Of course, I am always looking at the Windows CI (that I created). I think only Daniel and I currently can manage the Azure DevOps project, but you can use the following:

https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml#comment-triggers

/azp run windows

@azure-pipelines
Copy link

@azure-pipelines azure-pipelines bot commented Aug 27, 2020

Azure Pipelines successfully started running 1 pipeline(s).
@curl curl deleted a comment from azure-pipelines bot Aug 27, 2020
@mback2k mback2k closed this in 003e81e Aug 28, 2020
mback2k added a commit to mback2k/curl that referenced this pull request Aug 28, 2020
Learn from the way Cygwin handles and maps the WinSock events
to simulate correct and complete poll and select behaviour
according to Richard W. Stevens Network Programming book.

Follow up to curl#5867
mback2k added a commit that referenced this pull request Aug 28, 2020
Learn from the way Cygwin handles and maps the WinSock events
to simulate correct and complete poll and select behaviour
according to Richard W. Stevens Network Programming book.

Follow up to #5867
Closes #5879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.