Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add description about CI platforms to CONTRIBUTE.md #5882

Closed
wants to merge 1 commit into from

Conversation

@mback2k
Copy link
Member

mback2k commented Aug 28, 2020

An attempt to clarify the current CI platform state in the docs.

@mback2k mback2k requested review from bagder, jay and MarcelRaad Aug 28, 2020
@bagder
bagder approved these changes Aug 28, 2020
Copy link
Member

bagder left a comment

Excellent stuff!

Copy link
Member

MarcelRaad left a comment

👍

Copy link
Member

jay left a comment

I'd just say it as windows testing is flaky at the moment rather than a whole chart. Also "common errors and failures" is not defined (is it?). Anyway, I'm fine with it once the typos are addressed.

docs/CONTRIBUTE.md Outdated Show resolved Hide resolved
docs/CONTRIBUTE.md Outdated Show resolved Hide resolved
Reviewed-by: Daniel Stenberg
Reviewed-by: Marcel Raad
Reviewed-by: Jay Satiro

Closes #5882
@mback2k mback2k force-pushed the mback2k:docs-ci-state branch from da3657e to 3230629 Aug 29, 2020
@mback2k
Copy link
Member Author

mback2k commented Aug 29, 2020

I'd just say it as windows testing is flaky at the moment rather than a whole chart.

I prefer the whole chart to give detailed guidance for newcomers.

Also "common errors and failures" is not defined (is it?). Anyway, I'm fine with it once the typos are addressed.

I don't really mean "common" in the sense of "general" here, I mean it more like "recurring over multiple CI runs and variants" or "same errors appearing in different builds". I tried to update the short description to hopefully make this clearer. Please take a look.

@mback2k mback2k requested a review from jay Aug 29, 2020
@mback2k mback2k self-assigned this Aug 29, 2020
@jay
jay approved these changes Aug 29, 2020
@mback2k mback2k closed this in 61aab81 Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.