select: align poll emulation to return all relevant events

[mback2k]

The poll emulation via select already consumes POLLRDNORM,
POLLWRNORM and POLLRDBAND as input events. Therefore it
should also return them as output events if signaled.

Also fix indentation in input event handling block.

Assisted-by: Daniel Stenberg

Replaces #5852

[jay]

I don't know if this is right. For example you are always setting POLLRDNORM on POLLIN afterwards but afaics that flag was not necessarily set beforehand. My understanding of poll is it is only supposed to write bits that were passed in, with the exceptions noted below. I think I agree with @bagder maybe it's best to take a if it ain't broke don't fix it approach here.

from posix poll:
In each pollfd structure, poll() shall clear the revents member, except that where the application requested a report on a condition by setting one of the bits of events listed above, poll() shall set the corresponding bit in revents if the requested condition is true. In addition, poll() shall set the POLLHUP, POLLERR, and POLLNVAL flag in revents if the condition is true, even if the application did not set the corresponding bit in events.

[mback2k]

I don't know if this is right. For example you are always setting POLLRDNORM on POLLIN afterwards but afaics that flag was not necessarily set beforehand. My understanding of poll is it is only supposed to write bits that were passed in, with the exceptions noted below.

I don't think this is something that I am changing with this PR. The current code also sets POLLIN if that itself was not set, but instead POLLRDNORM was set. So I am basically extending it to be also the case the other way around. Of course, I can extend this PR to make sure to check for both flags being requested before setting them. Please see how the code already handles both types of flags on the pre-poll code path which I just want to reflect in the post-poll code path as well:

curl/lib/select.c

Lines 400 to 405 in 147eca8

	if(ufds[i].events & (POLLRDNORM|POLLIN))
	FD_SET(ufds[i].fd, &fds_read);
	if(ufds[i].events & (POLLWRNORM|POLLOUT))
	FD_SET(ufds[i].fd, &fds_write);
	if(ufds[i].events & (POLLRDBAND|POLLPRI))
	FD_SET(ufds[i].fd, &fds_err);

I think I agree with @bagder maybe it's best to take a if it ain't broke don't fix it approach here.

I somewhat agree on this, but I think the current code is partially broken, because it is not following the spec you referenced either. I will update this PR to reflect the spec even better.

[mback2k]

I updated the PR to be in line with the POSIX specification. This should also make sure there are no side effects, because we won't return the "new" flags POLLRDNORM, POLLWRNORM and POLLRDBAND if they were not requested by the caller beforehand.

[jay]

Fair enough, looks better now.

[mback2k]

@jay thank you very much! @bagder what do you think of this new variant?