Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: use `Curl_` as prefix for internal global symbols #5906

Closed
wants to merge 8 commits into from

Conversation

@bagder
Copy link
Member

bagder commented Sep 2, 2020

Here's a makeover to rename internally used structs that still were using curl_ prefix, despite our policy to only use that prefix for global symbols.

One of the primary points with insisting on the distinction is to make it easier for developers to read the code and see when types/names are private or not.

@bagder bagder added the tidy-up label Sep 2, 2020
bagder added 5 commits Sep 2, 2020
As internal global names should use captical C.
As internal global names should use captical C.
As internal global names should use captical C.
Internal names should not be prefixed "curl_"
Use uppercase C for internal symbols.
@bagder bagder force-pushed the bagder/uppercase-curl branch from 0e2f4e6 to 87bf895 Sep 2, 2020
bagder added 3 commits Sep 2, 2020
@bagder bagder closed this in 9b3f888 Sep 2, 2020
bagder added a commit that referenced this pull request Sep 2, 2020
As internal global names should use captical C.

Closes #5906
bagder added a commit that referenced this pull request Sep 2, 2020
As internal global names should use captical C.

Closes #5906
bagder added a commit that referenced this pull request Sep 2, 2020
Internal names should not be prefixed "curl_"

Closes #5906
bagder added a commit that referenced this pull request Sep 2, 2020
Use uppercase C for internal symbols.

Closes #5906
bagder added a commit that referenced this pull request Sep 2, 2020
Closes #5906
bagder added a commit that referenced this pull request Sep 2, 2020
Closes #5906
bagder added a commit that referenced this pull request Sep 2, 2020
Closes #5906
@bagder bagder deleted the bagder/uppercase-curl branch Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.