NTLM authentication fails when using proxy without username and password

[ustcqidi]

try to fix the issue #5911

[bagder]

Except for the compiler warnings it seems reasonable:

url.c:2385:9: error: initializing 'char *' with an expression of type 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
  char *proxyuser = data->set.str[STRING_PROXYUSERNAME] ? data->set.str[STRING_PROXYUSERNAME] : "";
        ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
url.c:2386:9: error: initializing 'char *' with an expression of type 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
  char *proxypasswd = data->set.str[STRING_PROXYPASSWORD] ? data->set.str[STRING_PROXYPASSWORD] : "";
        ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[ustcqidi]

Except for the compiler warnings it seems reasonable:

url.c:2385:9: error: initializing 'char *' with an expression of type 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
  char *proxyuser = data->set.str[STRING_PROXYUSERNAME] ? data->set.str[STRING_PROXYUSERNAME] : "";
        ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
url.c:2386:9: error: initializing 'char *' with an expression of type 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
  char *proxypasswd = data->set.str[STRING_PROXYPASSWORD] ? data->set.str[STRING_PROXYPASSWORD] : "";
        ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@bagder thanks for your review, I have updated the patch. Could you please help to review it again? Many thanks.

[bagder]

The CI builds still complain (run make checksrc to detect these yourself):

./url.c:2385:106: warning: Longer than 79 columns (LONGLINE)
   const char *proxyuser = data->set.str[STRING_PROXYUSERNAME] ? data->set.str[STRING_PROXYUSERNAME] : "";
./url.c:2386:108: warning: Longer than 79 columns (LONGLINE)
   const char *proxypasswd = data->set.str[STRING_PROXYPASSWORD] ? data->set.str[STRING_PROXYPASSWORD] : "";
checksrc: 0 errors and 2 warnings

[ustcqidi]

Have fixed the warning and verified with checksrc.bat. thanks @bagder

[ghost]

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

[ghost]

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

[bagder]

Thanks!