Fix connection reuse with IDN host names #592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the ACE form of IDN hostnames as key in the connection cache. Add new tests.
|
Thanks a lot. The level of detail and the included new test cases in this patch makes this one of the absolutely best newcomer patches we've received in a long time. A very big 👍 for that! |
|
Thank you for merging and for the kind words :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use the ACE form of IDN hostnames as key in the connection cache.
Previously, curl created multiple connections when following redirections from a server with an IDN hostname, e.g. http://äöü.example.com/page1 --> http://äöü.example.com/page2 . The Unicode hostname was used as a key for the connection cache, and for the second request, the ACE name was used to search an existing connection. Therefore curl did not find the existing connection.