Fix connection reuse with IDN host names #592

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mkauf
Contributor
mkauf commented Jan 7, 2016

Always use the ACE form of IDN hostnames as key in the connection cache.

Previously, curl created multiple connections when following redirections from a server with an IDN hostname, e.g. http://äöü.example.com/page1 --> http://äöü.example.com/page2 . The Unicode hostname was used as a key for the connection cache, and for the second request, the ACE name was used to search an existing connection. Therefore curl did not find the existing connection.

@mkauf mkauf Fix connection reuse with IDN host names
Use the ACE form of IDN hostnames as key in the connection cache.
Add new tests.
8bd8549
@bagder bagder self-assigned this Jan 7, 2016
@bagder bagder added a commit that closed this pull request Jan 7, 2016
@mkauf @bagder mkauf + bagder connection reuse: IDN host names fixed
Use the ACE form of IDN hostnames as key in the connection cache.  Add
new tests.

Closes #592
d9b4d1c
@bagder bagder closed this in d9b4d1c Jan 7, 2016
@bagder
Member
bagder commented Jan 7, 2016

Thanks a lot. The level of detail and the included new test cases in this patch makes this one of the absolutely best newcomer patches we've received in a long time. A very big 👍 for that!

@mkauf
Contributor
mkauf commented Jan 8, 2016

Thank you for merging and for the kind words :-)

@mkauf mkauf deleted the mkauf:idn-connection-reuse branch Jan 8, 2016
@mkauf mkauf restored the mkauf:idn-connection-reuse branch Jan 8, 2016
@mkauf mkauf deleted the mkauf:idn-connection-reuse branch Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment