New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection reuse with IDN host names #592

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mkauf
Contributor

mkauf commented Jan 7, 2016

Always use the ACE form of IDN hostnames as key in the connection cache.

Previously, curl created multiple connections when following redirections from a server with an IDN hostname, e.g. http://äöü.example.com/page1 --> http://äöü.example.com/page2 . The Unicode hostname was used as a key for the connection cache, and for the second request, the ACE name was used to search an existing connection. Therefore curl did not find the existing connection.

Fix connection reuse with IDN host names
Use the ACE form of IDN hostnames as key in the connection cache.
Add new tests.

@bagder bagder self-assigned this Jan 7, 2016

@bagder bagder closed this in d9b4d1c Jan 7, 2016

@bagder

This comment has been minimized.

Member

bagder commented Jan 7, 2016

Thanks a lot. The level of detail and the included new test cases in this patch makes this one of the absolutely best newcomer patches we've received in a long time. A very big 👍 for that!

@mkauf

This comment has been minimized.

Contributor

mkauf commented Jan 8, 2016

Thank you for merging and for the kind words :-)

@mkauf mkauf deleted the mkauf:idn-connection-reuse branch Jan 8, 2016

@mkauf mkauf restored the mkauf:idn-connection-reuse branch Jan 8, 2016

@mkauf mkauf deleted the mkauf:idn-connection-reuse branch Jan 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment