Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upaltsvc: inherit setting in curl_easy_duphandle #5923
Merged
Conversation
bagder
changed the title
bagder
added a commit
that referenced
this pull request
Sep 5, 2020
The cache content is not duplicated, like other caches, but the setting and specified file name are. Test 1908 is extended to verify this somewhat. Since the duplicated handle gets the same file name, the test unfortunately overwrites the same file twice (with different contents) which makes it hard to check automatically. Closes #5923
bagder
added a commit
that referenced
this pull request
Sep 5, 2020
The cache content is not duplicated, like other caches, but the setting and specified file name are. Test 1908 is extended to verify this somewhat. Since the duplicated handle gets the same file name, the test unfortunately overwrites the same file twice (with different contents) which makes it hard to check automatically. Closes #5923
The cache content is not duplicated, like other caches, but the setting and specified file name are. Test 1908 is extended to verify this somewhat. Since the duplicated handle gets the same file name, the test unfortunately overwrites the same file twice (with different contents) which makes it hard to check automatically. Closes #5923
bagder
merged commit f93455e
into
master
45 of 49 checks passed
45 of 49 checks passed
curl.curl (windows windows msys2_mingw32_debug_schannel)
windows windows msys2_mingw32_debug_schannel failed
Details
curl.curl (windows windows msys2_mingw64_debug_openssl)
windows windows msys2_mingw64_debug_openssl failed
Details
curl.curl (windows windows msys2_mingw64_debug_schannel)
windows windows msys2_mingw64_debug_schannel failed
Details
curl.curl (linux ubuntu disable_http_smtp_imap)
linux ubuntu disable_http_smtp_imap succeeded
Details
curl.curl (windows windows msys1_mingw32_debug_openssl)
windows windows msys1_mingw32_debug_openssl succeeded
Details
curl.curl (windows windows msys1_mingw32_debug_schannel)
windows windows msys1_mingw32_debug_schannel succeeded
Details
curl.curl (windows windows msys1_mingw64_debug_openssl)
windows windows msys1_mingw64_debug_openssl succeeded
Details
curl.curl (windows windows msys1_mingw64_debug_schannel)
windows windows msys1_mingw64_debug_schannel succeeded
Details
curl.curl (windows windows msys1_mingw_debug_openssl)
windows windows msys1_mingw_debug_openssl succeeded
Details
curl.curl (windows windows msys1_mingw_debug_schannel)
windows windows msys1_mingw_debug_schannel succeeded
Details
curl.curl (windows windows msys2_mingw32_debug_openssl)
windows windows msys2_mingw32_debug_openssl succeeded
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bagder commentedSep 5, 2020
The cache content is not duplicated, like other caches, but the setting
and specified file name are.
Test 1908 is extended to verify this somewhat. Since the duplicated
handle gets the same file name, the test unfortunately overwrites the
same file twice (with different contents) which makes it hard to check
automatically.