Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

altsvc: inherit setting in curl_easy_duphandle #5923

Merged
merged 1 commit into from Sep 6, 2020
Merged

Conversation

@bagder
Copy link
Member

bagder commented Sep 5, 2020

The cache content is not duplicated, like other caches, but the setting
and specified file name are.

Test 1908 is extended to verify this somewhat. Since the duplicated
handle gets the same file name, the test unfortunately overwrites the
same file twice (with different contents) which makes it hard to check
automatically.

@bagder bagder changed the title altsvc: ineherit setting in curl_easy_duphandle altsvc: inherit setting in curl_easy_duphandle Sep 5, 2020
@bagder bagder mentioned this pull request Sep 5, 2020
2 of 2 tasks complete
bagder added a commit that referenced this pull request Sep 5, 2020
The cache content is not duplicated, like other caches, but the setting
and specified file name are.

Test 1908 is extended to verify this somewhat. Since the duplicated
handle gets the same file name, the test unfortunately overwrites the
same file twice (with different contents) which makes it hard to check
automatically.

Closes #5923
@bagder bagder force-pushed the bagder/altsvc-duphandle branch from 0a7892e to 4ecc9fa Sep 5, 2020
bagder added a commit that referenced this pull request Sep 5, 2020
The cache content is not duplicated, like other caches, but the setting
and specified file name are.

Test 1908 is extended to verify this somewhat. Since the duplicated
handle gets the same file name, the test unfortunately overwrites the
same file twice (with different contents) which makes it hard to check
automatically.

Closes #5923
@bagder bagder force-pushed the bagder/altsvc-duphandle branch from 4ecc9fa to 11380f7 Sep 5, 2020
The cache content is not duplicated, like other caches, but the setting
and specified file name are.

Test 1908 is extended to verify this somewhat. Since the duplicated
handle gets the same file name, the test unfortunately overwrites the
same file twice (with different contents) which makes it hard to check
automatically.

Closes #5923
@bagder bagder force-pushed the bagder/altsvc-duphandle branch from 11380f7 to f93455e Sep 6, 2020
@bagder bagder closed this in f93455e Sep 6, 2020
@bagder bagder merged commit f93455e into master Sep 6, 2020
45 of 49 checks passed
45 of 49 checks passed
codeql
Details
fuzzing
Details
macos normal
Details
macos debug
Details
macos libssh2
Details
macos c-ares
Details
macos HTTP only
Details
macos SecureTransport metalink
Details
macos OpenSSL metalink
Details
macos LibreSSL metalink
Details
macos torture
Details
macos macOS 10.15
Details
macos cmake clang OpenSSL
Details
macos cmake clang LibreSSL
Details
macos cmake gcc-8 OpenSSL
Details
macos cmake gcc-8 LibreSSL
Details
macos cmake gcc-9 OpenSSL
Details
macos cmake gcc-9 LibreSSL
Details
curl.curl Build #20200906.5 had test failures
Details
curl.curl (windows windows msys2_mingw32_debug_schannel) windows windows msys2_mingw32_debug_schannel failed
Details
curl.curl (windows windows msys2_mingw64_debug_openssl) windows windows msys2_mingw64_debug_openssl failed
Details
curl.curl (windows windows msys2_mingw64_debug_schannel) windows windows msys2_mingw64_debug_schannel failed
Details
LGTM analysis: Python No code changes detected
Details
CodeQL No new alerts
Details
FreeBSD FreeBSD:freebsd-11-4 Task Summary
Details
FreeBSD FreeBSD:freebsd-12-1 Task Summary
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
buildbot/curl-unthreaded-solaris10-i386 Build done.
Details
buildbot/curl-unthreaded-solaris10-sparc Build done.
Details
buildbot/curl_winssl_cross_x64 Build done.
Details
buildbot/curl_winssl_cross_x64_dbg Build done.
Details
buildbot/curl_winssl_cross_x86 Build done.
Details
buildbot/curl_winssl_cross_x86_dbg Build done.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
curl.curl (linux ubuntu default) linux ubuntu default succeeded
Details
curl.curl (linux ubuntu disable_http_smtp_imap) linux ubuntu disable_http_smtp_imap succeeded
Details
curl.curl (linux ubuntu disable_ipv6) linux ubuntu disable_ipv6 succeeded
Details
curl.curl (linux ubuntu disable_thredres) linux ubuntu disable_thredres succeeded
Details
curl.curl (linux ubuntu http_only) linux ubuntu http_only succeeded
Details
curl.curl (linux ubuntu torture) linux ubuntu torture succeeded
Details
curl.curl (windows windows msys1_mingw32_debug_openssl) windows windows msys1_mingw32_debug_openssl succeeded
Details
curl.curl (windows windows msys1_mingw32_debug_schannel) windows windows msys1_mingw32_debug_schannel succeeded
Details
curl.curl (windows windows msys1_mingw64_debug_openssl) windows windows msys1_mingw64_debug_openssl succeeded
Details
curl.curl (windows windows msys1_mingw64_debug_schannel) windows windows msys1_mingw64_debug_schannel succeeded
Details
curl.curl (windows windows msys1_mingw_debug_openssl) windows windows msys1_mingw_debug_openssl succeeded
Details
curl.curl (windows windows msys1_mingw_debug_schannel) windows windows msys1_mingw_debug_schannel succeeded
Details
curl.curl (windows windows msys2_mingw32_debug_openssl) windows windows msys2_mingw32_debug_openssl succeeded
Details
deepcode-ci-bot Well done, no issues found!
Details
@bagder bagder deleted the bagder/altsvc-duphandle branch Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.